Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#18477 closed enhancement (fixed)

Update git_trac to the latest commit of the repository

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.8
Component: packages: standard Keywords:
Cc: jdemeyer, vbraun, vdelecroix Merged in:
Authors: Nathann Cohen Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 2fd06da (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by ncohen)

By updating Sage's shipped version of git_trac, we make it possible to checkout tickets without having a trac account.

http://www.steinertriples.fr/ncohen/tmp/git_trac-20150522.tar.bz2

Change History (15)

comment:1 Changed 4 years ago by ncohen

  • Status changed from new to needs_review

comment:2 Changed 4 years ago by ncohen

  • Branch set to public/18477
  • Commit set to 08af769b163b2e3e38485ad606386a1d73fd4ec4

comment:3 Changed 4 years ago by ncohen

  • Description modified (diff)

comment:4 Changed 4 years ago by ncohen

  • Summary changed from Update git_trac to the latest commit of the repo to Update git_trac to the latest commit of the repository

comment:5 Changed 4 years ago by jdemeyer

The tarball is missing a top-level directory (usually called src in Sage).

comment:6 Changed 4 years ago by ncohen

Arg, sorry for that. I built it with "git archive" but it was not such a good idea after all. Will be fixed in a second.

comment:7 Changed 4 years ago by git

  • Commit changed from 08af769b163b2e3e38485ad606386a1d73fd4ec4 to 2fd06dad9a9d3543efe5dffa69c1d96c7fe9e8c5

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2fd06datrac #18477: Update git_trac to the latest commit of the repository

comment:8 Changed 4 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:9 follow-up: Changed 4 years ago by jdemeyer

I would be even better if git trac checkout ... would automatically run git trac config if needed, but this is already nice.

comment:10 Changed 4 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer

comment:11 Changed 4 years ago by vbraun

  • Branch changed from public/18477 to 2fd06dad9a9d3543efe5dffa69c1d96c7fe9e8c5
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:12 in reply to: ↑ 9 ; follow-up: Changed 4 years ago by ncohen

  • Commit 2fd06dad9a9d3543efe5dffa69c1d96c7fe9e8c5 deleted

I would be even better if git trac checkout ... would automatically run git trac config if needed, but this is already nice.

Well. In terms of 'clean code', what would you think of a way to decorate functions which use a remote? The decorator would check that the remotes exist, and if they do not create them before running the function? Or do you think that it's 'oversolving' the problem?

Nathann

comment:13 in reply to: ↑ 12 ; follow-up: Changed 4 years ago by jdemeyer

Replying to ncohen:

Well. In terms of 'clean code', what would you think of a way to decorate functions which use a remote? The decorator would check that the remotes exist, and if they do not create them before running the function?

I think that's a good solution. Just make sure that the "ensure that the trac remote exists" function is cached, in case a scripts needs to call those functions many times.

But really, this is Volker's code, so it's better to ask him.

comment:14 in reply to: ↑ 13 Changed 4 years ago by ncohen

I think that's a good solution.

I trust your sense of 'cleanness' more than I trust mine on those matters.

But really, this is Volker's code, so it's better to ask him.

Yes of course.

Nathann

Note: See TracTickets for help on using tickets.