Opened 6 years ago
Closed 6 years ago
#18476 closed enhancement (fixed)
some cleanup in symbolic/
Reported by:  chapoton  Owned by:  

Priority:  minor  Milestone:  sage6.8 
Component:  symbolics  Keywords:  
Cc:  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  André Apitzsch 
Report Upstream:  N/A  Work issues:  
Branch:  330a9a8 (Commits)  Commit:  330a9a88a1c202d12f30111ac1cb49ff8ff43846 
Dependencies:  Stopgaps: 
Description (last modified by )
 put raise statements into python3 syntax
 correct some problems found by pyflakes
in the symbolic/ directory
Change History (10)
comment:1 Changed 6 years ago by
 Branch set to u/chapoton/18476
 Commit set to 8cc789edbb63928682517d102107a354296d07d3
 Description modified (diff)
 Status changed from new to needs_review
comment:2 Changed 6 years ago by
In src/sage/symbolic/assumptions.py
although it's a comment you should write except TypeError as mess
because mess
is used in the ifcondition or better remove the comment out lines.
The remaining looks good to me.
comment:3 Changed 6 years ago by
 Commit changed from 8cc789edbb63928682517d102107a354296d07d3 to 128d3ebbad4ff53f9217327868f18d5a4d306c2a
comment:4 Changed 6 years ago by
done
comment:5 Changed 6 years ago by
 Reviewers set to André Apitzsch
 Status changed from needs_review to positive_review
comment:6 Changed 6 years ago by
 Status changed from positive_review to needs_work
Documentation doesn't build
comment:7 Changed 6 years ago by
 Commit changed from 128d3ebbad4ff53f9217327868f18d5a4d306c2a to 330a9a88a1c202d12f30111ac1cb49ff8ff43846
Branch pushed to git repo; I updated commit sha1. New commits:
330a9a8  trac #18476 remove brun function

comment:8 Changed 6 years ago by
 Status changed from needs_work to needs_review
comment:9 Changed 6 years ago by
 Status changed from needs_review to positive_review
comment:10 Changed 6 years ago by
 Branch changed from u/chapoton/18476 to 330a9a88a1c202d12f30111ac1cb49ff8ff43846
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
spring cleanup of symbolic/ : py3 raise syntax and pyflakes found errors