Opened 6 years ago

Closed 6 years ago

#18476 closed enhancement (fixed)

some cleanup in symbolic/

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-6.8
Component: symbolics Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: André Apitzsch
Report Upstream: N/A Work issues:
Branch: 330a9a8 (Commits) Commit: 330a9a88a1c202d12f30111ac1cb49ff8ff43846
Dependencies: Stopgaps:

Description (last modified by chapoton)

  • put raise statements into python3 syntax
  • correct some problems found by pyflakes

in the symbolic/ directory

Change History (10)

comment:1 Changed 6 years ago by chapoton

  • Branch set to u/chapoton/18476
  • Commit set to 8cc789edbb63928682517d102107a354296d07d3
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

​8cc789espring cleanup of symbolic/ : py3 raise syntax and pyflakes found errors

comment:2 Changed 6 years ago by aapitzsch

In src/sage/symbolic/assumptions.py although it's a comment you should write except TypeError as mess because mess is used in the if-condition or better remove the comment out lines.

The remaining looks good to me.

comment:3 Changed 6 years ago by git

  • Commit changed from 8cc789edbb63928682517d102107a354296d07d3 to 128d3ebbad4ff53f9217327868f18d5a4d306c2a

Branch pushed to git repo; I updated commit sha1. New commits:

​1c08dcdMerge branch 'u/chapoton/18476' into 6.8.b0
​128d3ebtrac #18476 remove 3 commented lines

comment:4 Changed 6 years ago by chapoton

done

comment:5 Changed 6 years ago by aapitzsch

  • Reviewers set to André Apitzsch
  • Status changed from needs_review to positive_review

comment:6 Changed 6 years ago by vbraun

  • Status changed from positive_review to needs_work

Documentation doesn't build

comment:7 Changed 6 years ago by git

  • Commit changed from 128d3ebbad4ff53f9217327868f18d5a4d306c2a to 330a9a88a1c202d12f30111ac1cb49ff8ff43846

Branch pushed to git repo; I updated commit sha1. New commits:

​330a9a8trac #18476 remove brun function

comment:8 Changed 6 years ago by chapoton

  • Status changed from needs_work to needs_review

comment:9 Changed 6 years ago by aapitzsch

  • Status changed from needs_review to positive_review

comment:10 Changed 6 years ago by vbraun

  • Branch changed from u/chapoton/18476 to 330a9a88a1c202d12f30111ac1cb49ff8ff43846
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.