Opened 4 years ago

Closed 4 years ago

#18460 closed defect (fixed)

Broken (optional) doctests with bliss

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.8
Component: graph theory Keywords:
Cc: jdemeyer, azi Merged in:
Authors: Nathann Cohen Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: db9c4fc (Commits) Commit: db9c4fce5f1592ed49dbb5a1d3af479d73b455e3
Dependencies: Stopgaps:

Description

I still fail to see how we missed that in #17464 O_o

Nathann

Change History (8)

comment:1 Changed 4 years ago by ncohen

  • Branch set to public/18460
  • Status changed from new to needs_review

comment:2 Changed 4 years ago by git

  • Commit set to 71a8ccbba673db2451ea863de7b44942281ac6f4

Branch pushed to git repo; I updated commit sha1. New commits:

71a8ccbtrac #18460: Broken (optional) doctests with bliss

comment:3 Changed 4 years ago by git

  • Commit changed from 71a8ccbba673db2451ea863de7b44942281ac6f4 to db9c4fce5f1592ed49dbb5a1d3af479d73b455e3

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

db9c4fctrac #18460: Broken (optional) doctests with bliss

comment:4 follow-up: Changed 4 years ago by dcoudert

The patch ipasses all tests on bliss.pyx and generic_graph.py, before and after installing bliss. Should I do something special to ensure that optional tests are executed?

Why are you removing isomorphism test with bliss?

comment:5 in reply to: ↑ 4 Changed 4 years ago by ncohen

The patch ipasses all tests on bliss.pyx and generic_graph.py, before and after installing bliss. Should I do something special to ensure that optional tests are executed?

The option is "--optional=sage,bliss"

Why are you removing isomorphism test with bliss?

Well, because there is no is_isomophic function in the 'bliss' module. There use to be one, in th preliminary phases of the branch that added support for bliss, but it was never available in a release.

Nathann

comment:6 follow-up: Changed 4 years ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

For me the patch is good to go (install, test, doc, etc.).

One remark: it could be good practice to indicate in the ticket the optional parameters to do the tests.

comment:7 in reply to: ↑ 6 Changed 4 years ago by ncohen

One remark: it could be good practice to indicate in the ticket the optional parameters to do the tests.

In the ticket? Why O_o

It's all in the developer's manual O_o

Nathann

comment:8 Changed 4 years ago by vbraun

  • Branch changed from public/18460 to db9c4fce5f1592ed49dbb5a1d3af479d73b455e3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.