Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#18459 closed enhancement (fixed)

Upgrade 4ti2 package to version 1.6.5

Reported by: mkoeppe Owned by:
Priority: minor Milestone: sage-6.8
Component: packages: optional Keywords:
Cc: dimpase Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: da53185 (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by mkoeppe)

4ti2 version 1.6.5 was just ​released.

Just released a new version of the mathematical software 4ti2. Version 1.6.5 is a minor update, which improves error checking while reading zsolve input files.

It also corrects a mistake in the test-suite introduced in version 1.6.3 released last month, which is included in Sage at the moment and which might scare some users. (There was no actual bug.)

The manual has been updated to include a reference to commands and their options and a reference to the C API. All commands now support --help; and long options are now available on Mac OS X.

Should update the package to get these improvements; the updated manual may make it easier to support 4ti2's features in Sage (#18325) or perhaps to develop a library-based interface to 4ti2.

(Updated: This ticket was for update to 1.6.4; but I had to release another version, 1.6.5, which actually compiles with the gcc version that Sage uses.)

Download the 4ti2 tarfile from ​http://www.4ti2.de/version_1.6.5/4ti2-1.6.5.tar.gz to SAGEROOT/upstream, checkout the git branch and do sage -f 4ti2 to try the new package.

Change History (11)

comment:1 Changed 6 years ago by mkoeppe

  • Description modified (diff)
  • Summary changed from Upgrade 4ti2 package to version 1.6.4 to Upgrade 4ti2 package to version 1.6.5

comment:2 Changed 6 years ago by mkoeppe

  • Branch set to u/mkoeppe/upgrade_4ti2_package_to_version_1_6_4

comment:3 Changed 6 years ago by mkoeppe

  • Commit set to 8d60aa09d85c3dd0c1b579174038411515c83966
  • Status changed from new to needs_review

New commits:

8d60aa0Update 4ti2 spkg scripts to version 1.6.5, add spkg-check

comment:4 Changed 6 years ago by dimpase

well, shouldn't it be Matthias, not Dima:

[[[ +=== 4ti2-1.6.5 (Dima Pasechnik, May 19, 2015) === }}}

comment:5 Changed 6 years ago by dimpase

  • Authors set to Matthias Koeppe
  • Branch changed from u/mkoeppe/upgrade_4ti2_package_to_version_1_6_4 to public/18459
  • Commit changed from 8d60aa09d85c3dd0c1b579174038411515c83966 to da53185bf24d71bf4bfffd487eb2a0ddb2622b19
  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

New commits:

8d60aa0Update 4ti2 spkg scripts to version 1.6.5, add spkg-check
da53185fix the author's name

comment:6 follow-up: Changed 6 years ago by ncohen

HMmmmmm.. If I make no mistake we dropped the "changelog" section of SPKG.txt when we switched to new-style packages. This, because the changelog is part of Sage's git tree.

Nathann

comment:7 in reply to: ↑ 6 Changed 6 years ago by dimpase

Replying to ncohen:

HMmmmmm.. If I make no mistake we dropped the "changelog" section of SPKG.txt when we switched to new-style packages. This, because the changelog is part of Sage's git tree.

IMHO one needs to specify what should be in the "main" commit message on such a ticket (do you often do multi-line commit messages?), otherwise this is not a sufficient replacement for SPKG.txt...

comment:8 Changed 6 years ago by ncohen

IMHO one needs to specify what should be in the "main" commit message on such a ticket (do you often do multi-line commit messages?), otherwise this is not a sufficient replacement for SPKG.txt...

I do not see any reason why packages should be handled differently from the rest of Sage's source code. How can you defend a SPKG.txt file for packages, and regular git logs for everything else?

Regardless of that, I am only telling you that the standard now is apparently to strip changelogs. So expect it to happen in the future, if somebody eventually touches this package.

Nathann

Last edited 6 years ago by ncohen (previous) (diff)

comment:9 Changed 6 years ago by vbraun

  • Branch changed from public/18459 to da53185bf24d71bf4bfffd487eb2a0ddb2622b19
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:10 follow-up: Changed 6 years ago by jdemeyer

  • Commit da53185bf24d71bf4bfffd487eb2a0ddb2622b19 deleted

FYI: doctests don't pass, so the package was moved to experimental.

comment:11 in reply to: ↑ 10 Changed 6 years ago by dimpase

Replying to jdemeyer:

FYI: doctests don't pass, so the package was moved to experimental.

Jeroen, wat is aan de hand, since when are you allowed to override collective decisions of making a package optional?!

Note: See TracTickets for help on using tickets.