Opened 6 years ago

Closed 6 years ago

#18457 closed defect (fixed)

Fix sage-download-file --print-fastest-mirror

Reported by: jhpalmieri Owned by:
Priority: critical Milestone: sage-6.8
Component: packages: optional Keywords:
Cc: Merged in:
Authors: John Palmieri Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: cff0472 (Commits) Commit: cff0472662fc4b479204ddfd2a1ed4740697e01c
Dependencies: Stopgaps:

Description

Trac #15642 broke the command sage-download-file --print-fastest-mirror: that command returns

Downloading the Sage mirror list
Searching fastest mirror
  162ms: http://echidna.maths.usyd.edu.au/sage/
  293ms: http://ftp.leg.uct.ac.za/pub/packages/sage/
  137ms: http://ftp.riken.jp/sagemath/
  150ms: http://ftp.tsukuba.wide.ad.jp/software/sage/
  142ms: http://ftp.yz.yamagata-u.ac.jp/pub/math/sage/
  199ms: http://linorg.usp.br/sage/
  162ms: http://mirror.aarnet.edu.au/pub/sage/
  175ms: http://mirror.switch.ch/mirror/sagemath/
  370ms: http://mirror.ufs.ac.za/sagemath/
  210ms: http://mirror.yandex.ru/mirrors/sage.math.washington.edu/
  193ms: http://mirrors.fe.up.pt/pub/sage/
   74ms: http://mirrors.mit.edu/sage/
  216ms: http://mirrors.ustc.edu.cn/sagemath/
  205ms: http://sagemath.c3sl.ufpr.br/
  673ms: http://sagemath.mirror.ac.za/
  370ms: http://sagemath.polytechnic.edu.na/
  171ms: http://www-ftp.lip6.fr/pub/math/sagemath/
    8ms: http://www.cecm.sfu.ca/sage/
  171ms: http://www.mirrorservice.org/sites/www.sagemath.org/
Fastest mirror: http://www.cecm.sfu.ca/sage/
http://www.cecm.sfu.ca/sage/

rather than just the URL for a single server (i.e., the last line in this output).

Change History (5)

comment:1 Changed 6 years ago by jhpalmieri

  • Branch set to u/jhpalmieri/fastest-mirror

comment:2 Changed 6 years ago by jhpalmieri

  • Commit set to cff0472662fc4b479204ddfd2a1ed4740697e01c
  • Status changed from new to needs_review

New commits:

cff0472#18457: fix sage-download-file --print-fastest-mirror

comment:3 follow-up: Changed 6 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

I see, fails if the mirror list hasn't been downloaded yet. Passing verbose=bool flags around is kind of fugly but we can refactor it later

comment:4 in reply to: ↑ 3 Changed 6 years ago by jhpalmieri

Replying to vbraun:

I see, fails if the mirror list hasn't been downloaded yet.

Right.

Passing verbose=bool flags around is kind of fugly but we can refactor it later

Yes, I thought briefly about some other choices, like redirecting output temporarily, but this was easy to do, and it's clear what's going on.

comment:5 Changed 6 years ago by vbraun

  • Branch changed from u/jhpalmieri/fastest-mirror to cff0472662fc4b479204ddfd2a1ed4740697e01c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.