Opened 12 years ago

Closed 12 years ago

#1845 closed defect (fixed)

[with patch, spkg, with positive review] list_plot3d should be able to accept lists of points in arbitrary positions

Reported by: jkantor Owned by: was
Priority: major Milestone: sage-2.10.1
Component: graphics Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Attachments (1)

trac-1845-fix-doctest.patch (870 bytes) - added by cwitty 12 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 12 years ago by mabshoff

  • Milestone set to sage-2.10.1

comment:2 Changed 12 years ago by cwitty

  • Description modified (diff)

Changed 12 years ago by cwitty

comment:3 Changed 12 years ago by cwitty

  • Summary changed from [with patch, spkg] list_plot3d should be able to accept lists of points in arbitrary positions to [with patch, spkg, with positive review] list_plot3d should be able to accept lists of points in arbitrary positions

Code looks good; doctests pass in sage/plot. I went through all the doctests by hand and they all work and look pretty. One of the doctests was malformed (syntax error); the attached trac-1845-fix-doctest.patch fixes that.

I did not look at differences between the old and new scipy_sandbox, or check old functionality of that spkg.

To apply: apply list_plot3d.hg, then trac-1845-fix-doctest.patch; and install the new scipy_sandbox spkg.

comment:4 Changed 12 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 2.10.1.rc1: the bundle and updated scipy_sandbox as well as cwitty's doctest fix patch.

Note: See TracTickets for help on using tickets.