Opened 6 years ago

Closed 6 years ago

#18445 closed defect (fixed)

Make Graph.sparse6 work on non-integer graphs

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.7
Component: graph theory Keywords:
Cc: borassi, dcoudert, vdelecroix Merged in:
Authors: Nathann Cohen Reviewers: Michele Borassi
Report Upstream: N/A Work issues:
Branch: 681b67b (Commits) Commit: 681b67b8a36069d552bc24486b680ed3545bf832
Dependencies: Stopgaps:


Right now:

sage: g = graphs.KneserGraph(5,2)
sage: g.size()
sage: Graph(g.sparse6_string()).size()

Change History (5)

comment:1 Changed 6 years ago by ncohen

  • Branch set to u/ncohen/18445
  • Cc borassi dcoudert vdelecroix added
  • Status changed from new to needs_review

comment:2 Changed 6 years ago by git

  • Commit set to 681b67b8a36069d552bc24486b680ed3545bf832

Branch pushed to git repo; I updated commit sha1. New commits:

681b67btrac #18445: Make Graph.sparse6 work on non-integer graphs

comment:3 Changed 6 years ago by borassi

  • Reviewers set to Michele Borassi
  • Status changed from needs_review to positive_review

I have checked the code, and I have no comment, or suggestion on how to improve it. Positive review!

comment:4 Changed 6 years ago by ncohen

Thanks !


comment:5 Changed 6 years ago by vbraun

  • Branch changed from u/ncohen/18445 to 681b67b8a36069d552bc24486b680ed3545bf832
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.