Opened 12 years ago

Closed 12 years ago

#1844 closed defect (fixed)

[with patch, needs review] Get doctest coverage in sage/modular/modform up to 100%

Reported by: craigcitro Owned by: craigcitro
Priority: major Milestone: sage-2.10.1
Component: modular forms Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

This patch brings doctest coverage up to 100% for every file in sage/modular/modform except for find_generators.py, which isn't imported into sage by default anyway. Needless to say, there are lots of small fixes and whatnot.

Attachments (4)

modform-doctest.hg (55.6 KB) - added by craigcitro 12 years ago.
1844.patch (115.1 KB) - added by craigcitro 12 years ago.
1844-2.patch (115.4 KB) - added by mhansen 12 years ago.
1844-2a.patch (2.6 KB) - added by craigcitro 12 years ago.

Download all attachments as: .zip

Change History (10)

Changed 12 years ago by craigcitro

comment:1 Changed 12 years ago by mhansen

  • Summary changed from [with bundle] Get doctest coverage in sage/modular/modform up to 100% to [with bundle, needs review] Get doctest coverage in sage/modular/modform up to 100%

comment:2 Changed 12 years ago by craigcitro

  • Status changed from new to assigned

comment:3 Changed 12 years ago by craigcitro

  • Summary changed from [with bundle, needs review] Get doctest coverage in sage/modular/modform up to 100% to [with patch, needs review] Get doctest coverage in sage/modular/modform up to 100%

I'm adding a patch that one should use *instead* of the .hg bundle above. (It's a patch with *just* the modular form changes, as opposed to a lot of the junk that made it into my bundle.)

Changed 12 years ago by craigcitro

Changed 12 years ago by mhansen

comment:4 Changed 12 years ago by mhansen

I added a new patch which should apply cleanly against 2.10.

Changed 12 years ago by craigcitro

comment:5 Changed 12 years ago by craigcitro

One should apply 1844-2.patch and then 1844-2a.patch from a clean 2.10 install. (The 2a is a very small patch.)

This should be ready to go. *crosses fingers*

comment:6 Changed 12 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged 1844-2.patch and 1844-2a.patch in Sage 2.10.1.alpha1 - finally :)

Note: See TracTickets for help on using tickets.