Opened 15 years ago

Closed 15 years ago

#1843 closed enhancement (fixed)

[with patch; positive review] cputime for gp interface

Reported by: William Stein Owned by: William Stein
Priority: major Milestone: sage-2.10.1
Component: interfaces Keywords:
Cc: Martin Albrecht Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description


Attachments (2)

trac-1843.patch (1.6 KB) - added by William Stein 15 years ago.
trac-1843-part2.patch (1.7 KB) - added by William Stein 15 years ago.
this adds doctests (apply both patches)

Download all attachments as: .zip

Change History (6)

Changed 15 years ago by William Stein

Attachment: trac-1843.patch added

comment:1 Changed 15 years ago by Martin Albrecht

Summary: [with patch; needs review] cputime for gp interface[with patch; mostly positive review] cputime for gp interface

The actual code looks good, but note that

  • no doctests were added
  • this patch will conflict with #1714 (but that is my fault because I didn't appropriately describe the attached patch in the ticket description)

comment:2 Changed 15 years ago by Martin Albrecht

Cc: Martin Albrecht added

Changed 15 years ago by William Stein

Attachment: trac-1843-part2.patch added

this adds doctests (apply both patches)

comment:3 Changed 15 years ago by Mike Hansen

Summary: [with patch; mostly positive review] cputime for gp interface[with patch; positive review] cputime for gp interface

They both apply and work for me.

comment:4 Changed 15 years ago by Michael Abshoff

Resolution: fixed
Status: newclosed

Merged in Sage 2.10.1.alpha1

Note: See TracTickets for help on using tickets.