Opened 12 years ago

Closed 12 years ago

#1843 closed enhancement (fixed)

[with patch; positive review] cputime for gp interface

Reported by: was Owned by: was
Priority: major Milestone: sage-2.10.1
Component: interfaces Keywords:
Cc: malb Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description


Attachments (2)

trac-1843.patch (1.6 KB) - added by was 12 years ago.
trac-1843-part2.patch (1.7 KB) - added by was 12 years ago.
this adds doctests (apply both patches)

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by was

comment:1 Changed 12 years ago by malb

  • Summary changed from [with patch; needs review] cputime for gp interface to [with patch; mostly positive review] cputime for gp interface

The actual code looks good, but note that

  • no doctests were added
  • this patch will conflict with #1714 (but that is my fault because I didn't appropriately describe the attached patch in the ticket description)

comment:2 Changed 12 years ago by malb

  • Cc malb added

Changed 12 years ago by was

this adds doctests (apply both patches)

comment:3 Changed 12 years ago by mhansen

  • Summary changed from [with patch; mostly positive review] cputime for gp interface to [with patch; positive review] cputime for gp interface

They both apply and work for me.

comment:4 Changed 12 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 2.10.1.alpha1

Note: See TracTickets for help on using tickets.