Opened 6 years ago

Closed 6 years ago

#18422 closed defect (fixed)

Documentation bug for binary quadratic form action

Reported by: roed Owned by:
Priority: minor Milestone: sage-6.7
Component: quadratic forms Keywords: documentation
Cc: Merged in:
Authors: David Roe Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: a57fad6 (Commits, GitHub, GitLab) Commit: a57fad6f3cac6106d96b4e973903f02647258565
Dependencies: Stopgaps:

Status badges

Description

The documentation of matrix_action_left and matrix_action_right for binary quadratic forms are reversed.

sage: Q = BinaryQF([1,2,3]); Q
x^2 + 2*x*y + 3*y^2
sage: A = matrix(QQ,2,2,[1,2,3,4])
sage: R.<x,y> = QQ[]
sage: Q(x+2*y,3*x+4*y)
34*x^2 + 96*x*y + 68*y^2
sage: Q.matrix_action_left(A)
17*x^2 + 74*x*y + 81*y^2
sage: Q.matrix_action_left?
...
Here the action of the matrix `M = \begin{pmatrix} a & b \\ c & d
\end{pmatrix}` on the form `Q(x, y)` produces the form `Q(ax+by,
cx+dy)`.
...

Change History (4)

comment:1 Changed 6 years ago by roed

  • Branch set to u/roed/t/18422

comment:2 Changed 6 years ago by roed

  • Authors set to David Roe
  • Commit set to a57fad6f3cac6106d96b4e973903f02647258565
  • Keywords documentation added
  • Status changed from new to needs_review

New commits:

a57fad6Fix documentation of binary quadratic form action

comment:3 Changed 6 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

lgtm

comment:4 Changed 6 years ago by vbraun

  • Branch changed from u/roed/t/18422 to a57fad6f3cac6106d96b4e973903f02647258565
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.