Opened 7 years ago
Closed 7 years ago
#18403 closed defect (fixed)
Deprecate the 'dev' scripts
Reported by: | ncohen | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.7 |
Component: | scripts | Keywords: | |
Cc: | vdelecroix | Merged in: | |
Authors: | Nathann Cohen | Reviewers: | Jeroen Demeyer |
Report Upstream: | N/A | Work issues: | |
Branch: | ad79214 (Commits, GitHub, GitLab) | Commit: | ad792145eeac7cc13c16efd2be9a6ac392bd29f0 |
Dependencies: | Stopgaps: |
Description
Since #17555 the 'dev' scripts have been removed from Sage's documentation. They have been kept around 'for those who still use them' yet should be removed in the long run, to be replaced with 'git-trac'.
With this branch, a deprecation warning is raised when it should to warn everybody who uses them.
See https://groups.google.com/d/topic/sage-devel/qMtxE-UFbZY/discussion
Change History (12)
comment:1 Changed 7 years ago by
- Branch set to public/18403
comment:2 Changed 7 years ago by
- Status changed from new to needs_review
comment:3 Changed 7 years ago by
- Commit set to cbdd5816aa3066eb2c06fe484971d050f0b0d8ed
comment:4 Changed 7 years ago by
- Created changed from 05/12/15 07:56:19 to 05/12/15 07:56:19
- Modified changed from 05/12/15 07:58:46 to 05/12/15 07:58:46
- Status changed from needs_review to positive_review
comment:5 Changed 7 years ago by
- Reviewers set to Jeroen Demeyer
comment:6 follow-up: ↓ 7 Changed 7 years ago by
Oh. Timestamps? :-P
Thanks Jeroen!
comment:7 in reply to: ↑ 6 ; follow-up: ↓ 8 Changed 7 years ago by
Replying to ncohen:
Oh. Timestamps?
:-P
Just for fun, I actually used the dev
scripts to review this ticket. They somehow create a message like that.
Let me also repeat that I oppose removing the dev scripts as long as git-trac
does not support checking out tickets "out of the box".
comment:8 in reply to: ↑ 7 Changed 7 years ago by
Just for fun, I actually used the
dev
scripts to review this ticket. They somehow create a message like that.
Oh. I thought that it was a brand-new answer to the positive_review/needs_work
affair.
Let me also repeat that I oppose removing the dev scripts as long as
git-trac
does not support checking out tickets "out of the box".
Yeah yeah. Vincent and I intend to see it solved soon anyway.
Nathann
comment:9 Changed 7 years ago by
- Status changed from positive_review to needs_work
sage -t --long src/sage/tests/cmdline.py ********************************************************************** File "src/sage/tests/cmdline.py", line 481, in sage.tests.cmdline.test_executable Failed example: ret, err Expected: (0, '') Got: (0, "/Users/buildslave-sage/slave/sage_git/build/src/bin/sage-dev:256: DeprecationWarning: the 'dev' scripts are deprecated. Please use 'git-trac' instead (see the developer's manual)\nSee http://trac.sagemath.org/18403 for details.\n kwds['description'] = get_help(obj._sagedev)['return']\n") ********************************************************************** 1 item had failures: 1 of 239 in sage.tests.cmdline.test_executable [238 tests, 1 failure, 73.62 s]
comment:10 Changed 7 years ago by
- Commit changed from cbdd5816aa3066eb2c06fe484971d050f0b0d8ed to ad792145eeac7cc13c16efd2be9a6ac392bd29f0
Branch pushed to git repo; I updated commit sha1. New commits:
ad79214 | trac #18403: Broken doctest
|
comment:11 Changed 7 years ago by
- Status changed from needs_work to positive_review
comment:12 Changed 7 years ago by
- Branch changed from public/18403 to ad792145eeac7cc13c16efd2be9a6ac392bd29f0
- Resolution set to fixed
- Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
trac #18403: Deprecate the 'dev' scripts