Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#18399 closed defect (fixed)

projective automorphism group fails for homogenized maps

Reported by: bhutz Owned by: bhutz
Priority: minor Milestone: sage-6.8
Component: algebraic geometry Keywords: projective morphism
Cc: Merged in:
Authors: Ben Hutz Reviewers: Grayson Jorgenson
Report Upstream: N/A Work issues:
Branch: 62ce7b2 (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by bhutz)

When the numerator is a constant, the .polynomial() conversion returns a different variable than the denominator. This is the expected behavior from the documentation of those functions. So this ticket will change how the conversion is done.

Example that fails


Change History (7)

comment:1 Changed 3 years ago by bhutz

  • Branch set to u/bhutz/ticket/18399
  • Created changed from 05/11/15 00:56:31 to 05/11/15 00:56:31
  • Modified changed from 05/11/15 00:56:31 to 05/11/15 00:56:31

comment:2 Changed 3 years ago by bhutz

  • Commit set to 6c04c13be814efb25bae9ebaa71b0d9daecca608
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

6c04c1318399: fix bug in projective morphism automorphism group

comment:3 Changed 3 years ago by gjorgenson

Everything looks good, but I think the ticket example should be added to the documentation as a test or example to demonstrate the fix.

comment:4 Changed 3 years ago by git

  • Commit changed from 6c04c13be814efb25bae9ebaa71b0d9daecca608 to 62ce7b2c725b0fed6d0e4a6f922f521761776a1e

Branch pushed to git repo; I updated commit sha1. New commits:

62ce7b218399: example added

comment:5 Changed 3 years ago by gjorgenson

  • Reviewers set to Grayson Jorgenson
  • Status changed from needs_review to positive_review

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/bhutz/ticket/18399 to 62ce7b2c725b0fed6d0e4a6f922f521761776a1e
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:7 Changed 3 years ago by bhutz

  • Commit 62ce7b2c725b0fed6d0e4a6f922f521761776a1e deleted
  • Milestone changed from sage-6.7 to sage-6.8
Note: See TracTickets for help on using tickets.