Opened 5 years ago

Last modified 3 years ago

#18390 new enhancement

cleanup variable factories — at Version 2

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-6.7
Component: algebra Keywords:
Cc: mforets Merged in:
Authors: Vincent Delecroix Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by vdelecroix)

The PolynomialRing factory is written in a very complicated way and is slightly different to FreeAlgebra. In this ticket, we normalize the inputs of all factories involving variables.

Some changes are noticeable

  1. the following will now raise TypeError
    sage: R.<a,b> = PolynomialRing(QQ, ('a', 'b'))
    sage: A.<x,y,z> = FreeAlgebra(QQ, 'x,y,z')
  1. The many versions are normalize_names are fused in sage.misc.variables.normalize_names
  1. Deprecations:
    • the var_array argument in PolynomialRing
    • the methods normalize_names, _certify_name of CategoryObject

As a sided effect, we got some speedup in polynomial ring creation!

Change History (2)

comment:1 Changed 5 years ago by vdelecroix

  • Description modified (diff)
  • Summary changed from cleanup polynomial ring factory to cleanup variable factories

comment:2 Changed 5 years ago by vdelecroix

  • Description modified (diff)
Note: See TracTickets for help on using tickets.