[with script; positive] sage-crap: incorporate this script into sage and start using it before each release.

[was]

I BSD license this file

* Copyright (c) 2008, William Stein (with permission)
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
*     * Redistributions of source code must retain the above copyright
*       notice, this list of conditions and the following disclaimer.
*     * Redistributions in binary form must reproduce the above copyright
*       notice, this list of conditions and the following disclaimer in the
*       documentation and/or other materials provided with the distribution.
*     * Neither the name of the Sage Project nor the
*       names of its contributors may be used to endorse or promote products
*       derived from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY WILLIAM STEIN ``AS IS'' AND ANY
* EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
* WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL William Stein BE LIABLE FOR ANY
* DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

[was]

See ​http://8tb.us/home/boothby/crap.patch

[boothby]

The attached patch integrates sage-crap, and works on my machines. (debian xeon / ubuntu 32bit)

[mabshoff]

A couple remarks:

• is this script still destructive? In that care it should be mentioned in the help
• the script does deal with spkgs and not tars per se - maybe the help in sage-sage should be changed?

Other than we might want to add a -crapall option since that is likely the default way one would deploy such a script, i.e. before a release. Maybe even adding a crap score might be a good thing :)

Cheers,

Michael

[was]

The referee report is above by malb. William Stein will do the work to fix this patch.

[was]

Example of using this with runlevel=1 on sage-3.0.3.alpha2 -- where we see there is some crap!:

was@sage:~/build/sage-3.0.3.alpha2$ ./sage -crap sage-3.0.3.alpha2.tar 
/home/was/.sage/temp/sage/32206/dir_0/sage-3.0.3.alpha2.tar
runlevel=  1
/home/was/.sage/temp/sage/32206/dir_0/sage-3.0.3.alpha2/spkg/standard/cddlib-094b.p2/src/src-gmp/.DS_Store: JVT NAL sequence
/home/was/.sage/temp/sage/32206/dir_0/sage-3.0.3.alpha2/spkg/standard/cddlib-094b.p2/src/src/.DS_Store: JVT NAL sequence
/home/was/.sage/temp/sage/32206/dir_0/sage-3.0.3.alpha2/spkg/standard/cddlib-094b.p2/src/lib-src/.DS_Store.1: JVT NAL sequence
/home/was/.sage/temp/sage/32206/dir_0/sage-3.0.3.alpha2/spkg/standard/cddlib-094b.p2/src/lib-src/.DS_Store: empty
/home/was/.sage/temp/sage/32206/dir_0/sage-3.0.3.alpha2/spkg/standard/cddlib-094b.p2/src/lib-src-gmp/.DS_Store.1: JVT NAL sequence
/home/was/.sage/temp/sage/32206/dir_0/sage-3.0.3.alpha2/spkg/standard/cddlib-094b.p2/src/lib-src-gmp/.DS_Store: empty
/home/was/.sage/temp/sage/32206/dir_0/sage-3.0.3.alpha2/spkg/standard/cddlib-094b.p2/src/doc/.DS_Store.1: JVT NAL sequence
/home/was/.sage/temp/sage/32206/dir_0/sage-3.0.3.alpha2/spkg/standard/cddlib-094b.p2/src/doc/cddlibman.aux: LaTeX auxiliary file
/home/was/.sage/temp/sage/32206/dir_0/sage-3.0.3.alpha2/spkg/standard/cddlib-094b.p2/src/doc/cddlibman.dvi: TeX DVI
/home/was/.sage/temp/sage/32206/dir_0/sage-3.0.3.alpha2/spkg/standard/cddlib-094b.p2/src/doc/cddlibman.toc: UNKNOWN
cddlibman.toc: LaTeX  table of contents

[was]

part 2 of the patch

[was]

I requested boothby to review this.

[was]

I consider my having read over it as a review and my little integration patch as part of that.

[mabshoff]

Merged in Sage 3.0.4.rc0. I also give this ticket a positive review and all issues that crop up will be dealt with on follow up tickets.

Cheers,

Michael

[mabshoff]

Merged in Sage 3.0.4.rc0