Opened 4 years ago

Closed 4 years ago

#18377 closed defect (fixed)

fixing doc in generic_graph_pyx

Reported by: chapoton Owned by:
Priority: major Milestone: sage-6.7
Component: graph theory Keywords:
Cc: ncohen Merged in:
Authors: Frédéric Chapoton Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: f0d24d6 (Commits) Commit: f0d24d6e3892b9863ef1ec22d265aaa773865198
Dependencies: #18296 Stopgaps:

Description

Some bad indentation

Change History (16)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/18377
  • Commit set to 4e94e9bc36f2bcfa799c4288dbd43f8516f607ae
  • Status changed from new to needs_review

New commits:

4e94e9btrac 18XXX fixing doc in generic_graph_pyx

comment:2 Changed 4 years ago by ncohen

  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

comment:3 Changed 4 years ago by chapoton

wooh, THAT was fast. I did not even had the time to check..

comment:4 Changed 4 years ago by ncohen

Well, I did not apply the branch nor pass the tests. I read the diff, however, and noticed nothing wrong which could potentially break the doc. Plus I have nothing against the changes that you make, soo.... :-P

comment:5 Changed 4 years ago by chapoton

  • Status changed from positive_review to needs_work

one second, please

comment:6 Changed 4 years ago by git

  • Commit changed from 4e94e9bc36f2bcfa799c4288dbd43f8516f607ae to 6a69ef67b3e01dd037ea98c3664dd9903af4d97c

Branch pushed to git repo; I updated commit sha1. New commits:

6a69ef6trac #18377 one more doc problem

comment:7 Changed 4 years ago by chapoton

Here was the one I was chasing for !

Now really ready for review. But I think this module is not included anywhere in the doc, maybe it should ?

comment:8 Changed 4 years ago by ncohen

Oh nono. That was fixed in #18296.

comment:9 Changed 4 years ago by chapoton

Then how to manage that ? I am not a git-wizard enough..

comment:10 Changed 4 years ago by ncohen

AHahah. Well... You have to become a git wizard :-P

It is not very complicated, though, as the name of the branch from #18296 still appears on the ticket: public/18296

You just have to merge your current branch with public/18296, and solve the conflicts that it will cause. Tell me if I am being too general. And if you do, please tell me how you use git (git trac? dev scripts? manually?)

Nathann

comment:11 Changed 4 years ago by git

  • Commit changed from 6a69ef67b3e01dd037ea98c3664dd9903af4d97c to f0d24d6e3892b9863ef1ec22d265aaa773865198

Branch pushed to git repo; I updated commit sha1. New commits:

4c94499trac #18296: Emphasize that Graph.subgraph_search ignores edge labels
93a1ecetrac #18296: Merged with 6.7.beta4
87d0324trac #18296: Broken doc
f0d24d6Merge branch 'public/18296' into 18377

comment:12 follow-up: Changed 4 years ago by chapoton

  • Dependencies set to #18296

I hope this is correct ? Never sure which way to merge..

I am using git manually.

comment:13 in reply to: ↑ 12 Changed 4 years ago by ncohen

  • Status changed from needs_work to positive_review

Yooooooo !

I hope this is correct ?

You did well.

Never sure which way to merge..

As far as I know, the world is split between those who don't care on one side, and those who care but cannot tell you when it actually matters.

Nathann

comment:14 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work

author name missing

comment:15 Changed 4 years ago by ncohen

  • Authors set to Frédéric Chapoton
  • Status changed from needs_work to positive_review

comment:16 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/18377 to f0d24d6e3892b9863ef1ec22d265aaa773865198
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.