Opened 2 years ago

Closed 2 years ago

#18374 closed defect (fixed)

Inconsistency in dimension of total ideals.

Reported by: mmarco Owned by:
Priority: major Milestone: sage-6.7
Component: algebra Keywords:
Cc: jacobkroeker Merged in:
Authors: Miguel Marco Reviewers: Grayson Jorgenson
Report Upstream: N/A Work issues:
Branch: b8051ee (Commits) Commit: b8051ee8f65fb6fca0d5f2b928942ff4054cbc23
Dependencies: Stopgaps:

Description

As mentioned in this sage-devel thread, there is an inconsistency in the dimension of total ideals.

Singular returns -1 for the rings it handles, whereas our fallback implementation returns 0.

Change History (7)

comment:1 Changed 2 years ago by mmarco

  • Branch set to bugdimension

comment:2 Changed 2 years ago by mmarco

  • Branch changed from bugdimension to u/mmarco/bugdimension

comment:3 Changed 2 years ago by git

  • Commit set to b8051ee8f65fb6fca0d5f2b928942ff4054cbc23

Branch pushed to git repo; I updated commit sha1. New commits:

b8051eeAdded the case dimension=-1 for total ideals over rings not handled by Singular.

comment:4 Changed 2 years ago by gjorgenson

Hi, this simplifies some of the functionality in a ticket I have been working on. Is this ticket ready for review?

comment:5 Changed 2 years ago by mmarco

  • Status changed from new to needs_review

Yes, it should be ready for review.

comment:6 Changed 2 years ago by gjorgenson

  • Reviewers set to Grayson Jorgenson
  • Status changed from needs_review to positive_review

Correct dimension is now returned and everything seems to be working properly.

comment:7 Changed 2 years ago by vbraun

  • Branch changed from u/mmarco/bugdimension to b8051ee8f65fb6fca0d5f2b928942ff4054cbc23
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.