Opened 4 years ago

Closed 4 years ago

#18362 closed defect (fixed)

upgrade to pynac-0.3.7

Reported by: rws Owned by:
Priority: major Milestone: sage-6.7
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Vincent Delecroix, François Bissey
Report Upstream: N/A Work issues:
Branch: 23892cb (Commits) Commit: 23892cb0a381dc2e8869b5c6980c7e504cbe6da6
Dependencies: #15642 Stopgaps:

Description

https://github.com/pynac/pynac/releases/download/pynac-0.3.7/pynac-0.3.7.tar.bz2

fixes five bugs plus Py3 support:

  • unhandled print order comparisons now call generic code instead of throwing exceptions (#17321)
  • fix bug in adds with simplified numerics (#12807)
  • check if infinity direction is numeric before comparing to zero (#13326)
  • treat muls and powers only with integer +/- one as special (#12257)
  • 00 is no longer an error (#18088)
  • latest version of AX_PYTHON_DEVEL macro

Change History (9)

comment:1 Changed 4 years ago by rws

  • Branch set to u/rws/upgrade_to_pynac_0_3_7

comment:2 Changed 4 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to 23892cb0a381dc2e8869b5c6980c7e504cbe6da6
  • Status changed from new to needs_review

New commits:

23892cb18362: upgrade to pynac-0.3.7; fix one changed doctest result

comment:3 follow-up: Changed 4 years ago by vdelecroix

All tests pass on my computer (Debian 64 bits).

comment:4 in reply to: ↑ 3 ; follow-up: Changed 4 years ago by rws

Replying to vdelecroix:

All tests pass on my computer (Debian 64 bits).

And if you don't set positive now the next version of develop will make a new pass necessary.

comment:5 in reply to: ↑ 4 Changed 4 years ago by vdelecroix

Replying to rws:

Replying to vdelecroix:

All tests pass on my computer (Debian 64 bits).

And if you don't set positive now the next version of develop will make a new pass necessary.

Would be better to test it on some linux 32 bits and an OS X. This is why I mentioned on which computer I did test it. If nobody shows up in a week for testing on other architecture, I will set the positive review.

comment:6 Changed 4 years ago by fbissey

Would be nice but not necessary. The reviewer cannot possibly review every combinations. That's the work of the bot. The reviewer should do what they see fit and do whatever exotic tests they have in mind. You have a concern about OS X? That's fine! Gut feeling or something you suspect from the review?

Anyway I'll quickly build it on OS X and do a few tests. Once it's done, I'll set it to positive review.

comment:7 Changed 4 years ago by fbissey

  • Reviewers set to Vincent Delecroix, François Bissey
  • Status changed from needs_review to positive_review

Ready for the bots.

comment:8 Changed 4 years ago by vbraun

  • Dependencies set to #15642

comment:9 Changed 4 years ago by vbraun

  • Branch changed from u/rws/upgrade_to_pynac_0_3_7 to 23892cb0a381dc2e8869b5c6980c7e504cbe6da6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.