Opened 7 years ago
Closed 7 years ago
#18352 closed enhancement (fixed)
Remove EMBEDDED_MODE in ISM
Reported by:  Andrey Novoseltsev  Owned by:  

Priority:  major  Milestone:  sage6.7 
Component:  numerical  Keywords:  
Cc:  Travis Scrimshaw, Volker Braun  Merged in:  
Authors:  Andrey Novoseltsev  Reviewers:  Volker Braun 
Report Upstream:  N/A  Work issues:  
Branch:  8686e1a (Commits, GitHub, GitLab)  Commit:  8686e1ac5462f69bf7ca392e3de5fc3a7c66a562 
Dependencies:  Stopgaps: 
Description (last modified by )
Interactive simplex method module relied on EMBEDDED_MODE to produce different LaTeX. Let's make switching away from MathJax manual.
Change History (9)
comment:1 Changed 7 years ago by
Authors:  → Andrey Novoseltsev 

Component:  PLEASE CHANGE → numerical 
Description:  modified (diff) 
Summary:  help → Remove EMBEDDED_MODE in ISM 
Type:  PLEASE CHANGE → enhancement 
comment:2 Changed 7 years ago by
Branch:  → u/novoselt/remove_embedded_mode_in_ism 

comment:3 Changed 7 years ago by
Cc:  Travis Scrimshaw Volker Braun added 

Commit:  → c6879c8c829adc192ac2c400548baa1c3bf6eb15 
Status:  new → needs_review 
comment:4 Changed 7 years ago by
Reviewers:  → Volker Braun 

Status:  needs_review → positive_review 
comment:5 Changed 7 years ago by
Status:  positive_review → needs_work 

Doctests errors in ISM, e.g.:
File "src/sage/numerical/interactive_simplex_method.py", line 85, in sage.numerical.interactive_simplex_method Failed example: P.run_simplex_method() Expected: '...' Got: %notruncate
comment:6 Changed 7 years ago by
Commit:  c6879c8c829adc192ac2c400548baa1c3bf6eb15 → 8686e1ac5462f69bf7ca392e3de5fc3a7c66a562 

Branch pushed to git repo; I updated commit sha1. New commits:
8686e1a  Fix doctests and drop \color tweaks  MathJax 2.5 does not need them.

comment:7 Changed 7 years ago by
Status:  needs_work → needs_review 

Sorry Volker  was in a rush to get a functioning server up and embarrassingly forgot about tests that used to have real LaTeX rather than something that MathJax likes... New commit is long, but mostly LaTeX changes to doctests and documentation  a few touches to the code remove {}wrapping of stuff after \color
commands.
comment:8 Changed 7 years ago by
Status:  needs_review → positive_review 

comment:9 Changed 7 years ago by
Branch:  u/novoselt/remove_embedded_mode_in_ism → 8686e1ac5462f69bf7ca392e3de5fc3a7c66a562 

Resolution:  → fixed 
Status:  positive_review → closed 
Note: See
TracTickets for help on using
tickets.
Completely trivial!
New commits:
Remove EMBEDDED_MODE from interactive_simplex_method.py