Opened 7 years ago

Closed 7 years ago

#18352 closed enhancement (fixed)

Remove EMBEDDED_MODE in ISM

Reported by: Andrey Novoseltsev Owned by:
Priority: major Milestone: sage-6.7
Component: numerical Keywords:
Cc: Travis Scrimshaw, Volker Braun Merged in:
Authors: Andrey Novoseltsev Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 8686e1a (Commits, GitHub, GitLab) Commit: 8686e1ac5462f69bf7ca392e3de5fc3a7c66a562
Dependencies: Stopgaps:

Status badges

Description (last modified by Andrey Novoseltsev)

Interactive simplex method module relied on EMBEDDED_MODE to produce different LaTeX. Let's make switching away from MathJax manual.

Change History (9)

comment:1 Changed 7 years ago by Andrey Novoseltsev

Authors: Andrey Novoseltsev
Component: PLEASE CHANGEnumerical
Description: modified (diff)
Summary: helpRemove EMBEDDED_MODE in ISM
Type: PLEASE CHANGEenhancement

comment:2 Changed 7 years ago by Andrey Novoseltsev

Branch: u/novoselt/remove_embedded_mode_in_ism

comment:3 Changed 7 years ago by Andrey Novoseltsev

Cc: Travis Scrimshaw Volker Braun added
Commit: c6879c8c829adc192ac2c400548baa1c3bf6eb15
Status: newneeds_review

Completely trivial!


New commits:

c6879c8Remove EMBEDDED_MODE from interactive_simplex_method.py

comment:4 Changed 7 years ago by Volker Braun

Reviewers: Volker Braun
Status: needs_reviewpositive_review

comment:5 Changed 7 years ago by Volker Braun

Status: positive_reviewneeds_work

Doctests errors in ISM, e.g.:

File "src/sage/numerical/interactive_simplex_method.py", line 85, in sage.numerical.interactive_simplex_method
Failed example:
    P.run_simplex_method()
Expected:
    '...'
Got:
    %notruncate

comment:6 Changed 7 years ago by git

Commit: c6879c8c829adc192ac2c400548baa1c3bf6eb158686e1ac5462f69bf7ca392e3de5fc3a7c66a562

Branch pushed to git repo; I updated commit sha1. New commits:

8686e1aFix doctests and drop \color tweaks - MathJax 2.5 does not need them.

comment:7 Changed 7 years ago by Andrey Novoseltsev

Status: needs_workneeds_review

Sorry Volker - was in a rush to get a functioning server up and embarrassingly forgot about tests that used to have real LaTeX rather than something that MathJax likes... New commit is long, but mostly LaTeX changes to doctests and documentation - a few touches to the code remove {}-wrapping of stuff after \color commands.

comment:8 Changed 7 years ago by Volker Braun

Status: needs_reviewpositive_review

comment:9 Changed 7 years ago by Volker Braun

Branch: u/novoselt/remove_embedded_mode_in_ism8686e1ac5462f69bf7ca392e3de5fc3a7c66a562
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.