#18339 closed defect (fixed)
gf2x's test suite may "pass" even though it actually failed — at Version 5
| Reported by: | leif | Owned by: | leif |
|---|---|---|---|
| Priority: | critical | Milestone: | sage-6.7 |
| Component: | packages: standard | Keywords: | make check do-check-mul.sh |
| Cc: | Merged in: | ||
| Authors: | Leif Leonhardy | Reviewers: | Sebastien Gouezel |
| Report Upstream: | Fixed upstream, but not in a stable release. | Work issues: | |
| Branch: | f25a702 (Commits, GitHub, GitLab) | Commit: | |
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
... make check-TESTS make[2]: Entering directory '/tmp/sage-build-tmp/gf2x-1.1.p1/src/tests' 1x1 2x2 3x3 4x4 5x5 6x6 7x7 8x8 9x9 20x20 100x20 100x100 failed : '100 100 cca56aa6 76540123' != '100 100 2269c4fa 76540123' Checking gf2x_mul_1_n against gf2x_addmul_1_n...ok PASS: do-check-mul.sh ============= 1 test passed ============= make[2]: Leaving directory '/tmp/sage-build-tmp/gf2x-1.1.p1/src/tests' make[1]: Leaving directory '/tmp/sage-build-tmp/gf2x-1.1.p1/src/tests' Making check in src make[1]: Entering directory '/tmp/sage-build-tmp/gf2x-1.1.p1/src/src' make check-am make[2]: Entering directory '/tmp/sage-build-tmp/gf2x-1.1.p1/src/src' make[2]: Nothing to be done for 'check-am'. make[2]: Leaving directory '/tmp/sage-build-tmp/gf2x-1.1.p1/src/src' make[1]: Leaving directory '/tmp/sage-build-tmp/gf2x-1.1.p1/src/src' real 0m0.647s user 0m0.910s sys 0m0.120s Deleting temporary build directory /tmp/sage-build-tmp/gf2x-1.1.p1 Finished installing gf2x-1.1.p1.spkg
(I wonder how many times that happened to other people without them noticing it...)
Upstream report:
https://gforge.inria.fr/tracker/index.php?func=detail&aid=18889&group_id=1874&atid=6979
Change History (5)
comment:1 Changed 7 years ago by
- Branch set to u/leif/gf2x_test_suite_bug
- Commit set to f25a702251f231841e44437cef31e70e871973d9
- Status changed from new to needs_review
comment:2 Changed 7 years ago by
Should the patch level get bumped?
Unless SAGE_CHECK is set, rebuilding doesn't make sense...
comment:3 Changed 7 years ago by
- Reviewers set to Sebastien Gouezel
- Status changed from needs_review to positive_review
Looks good to me.
comment:4 Changed 7 years ago by
- Branch changed from u/leif/gf2x_test_suite_bug to f25a702251f231841e44437cef31e70e871973d9
- Resolution set to fixed
- Status changed from positive_review to closed
comment:5 Changed 7 years ago by
- Commit f25a702251f231841e44437cef31e70e871973d9 deleted
- Description modified (diff)
Note: See
TracTickets for help on using
tickets.
New commits:
Add upstream patch to let gf2x's 'make check' actually fail on errors (#18339)