Opened 12 years ago

Closed 12 years ago

#1833 closed defect (fixed)

[with patch; positive review] plot3d and parametric_plot3d can be very slow on some inputs

Reported by: was Owned by: was
Priority: major Milestone: sage-2.10.1
Component: graphics Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description 

sage: x,y = var('x,y')
sage: plot3d(x*y, (x,-1,1), (y,-1,1))

is fast, but 

sage: x,y = var('x,y')
sage: plot3d(x*y, (-1,1), (-1,1))

is shockingly slow (and similar remarks for parametric plots). The attached patch fixes this problem.

This also fixes trac #1737.

Attachments (1)

trac-1833.patch​ (7.9 KB) - added by was 12 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 12 years ago by was

  • Component changed from algebraic geometry to graphics

comment:2 Changed 12 years ago by was

This patch also moves plot3d_adaptive into plot3d (i.e., as an option), and deprecates globally exposing plot3d_adaptive. This is natural to do in the context of this patch.

Changed 12 years ago by was

comment:3 Changed 12 years ago by mhansen

  • Summary changed from [with patch; needs review] plot3d and parametric_plot3d can be very slow on some inputs to [with patch; positive review] plot3d and parametric_plot3d can be very slow on some inputs

Looks good to me.

comment:4 Changed 12 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 2.10.1.alpha1

Note: See TracTickets for help on using tickets.