Opened 6 years ago

Closed 6 years ago

#18318 closed defect (fixed)

CryptoMiniSat Memleak

Reported by: malb Owned by:
Priority: major Milestone: sage-6.7
Component: packages: optional Keywords:
Cc: Merged in:
Authors: Martin Albrecht Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 9205d88 (Commits) Commit: 9205d8894938dd1381ca2e47aae750d4843a3db5
Dependencies: Stopgaps:

Description

The CryptoMiniSat? wrapper class's destructor does nothing which produces a pretty bad memleak.

  def __dealloc__(self):
    del self

Change History (7)

comment:1 Changed 6 years ago by git

  • Commit set to 9205d8894938dd1381ca2e47aae750d4843a3db5

Branch pushed to git repo; I updated commit sha1. New commits:

9205d88Fix memleak: cryptoMiniSat was never freed

comment:2 Changed 6 years ago by malb

  • Status changed from new to needs_review

comment:3 Changed 6 years ago by malb

  • Authors set to Martin Albrecht

comment:4 Changed 6 years ago by dimpase

  • Status changed from needs_review to positive_review

LGTM

comment:5 Changed 6 years ago by vbraun

  • Status changed from positive_review to needs_work

Missing reviewer name

comment:6 Changed 6 years ago by malb

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_work to positive_review

comment:7 Changed 6 years ago by vbraun

  • Branch changed from u/malb/cryptominisat-memleak to 9205d8894938dd1381ca2e47aae750d4843a3db5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.