Opened 6 years ago

Closed 6 years ago

#18316 closed defect (fixed)

Lcalc fails to build with GCC 5.x (C++ issue)

Reported by: leif Owned by: leif
Priority: critical Milestone: sage-6.7
Component: packages: standard Keywords: default parameters definition -fpermissive g++
Cc: Merged in:
Authors: Leif Leonhardy Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: dddef7f (Commits) Commit: dddef7fb2eb10c0ba472ee7087d33dd49c4e7acc
Dependencies: Stopgaps:

Description

GCC 5.1 (i.e., g++) again got stricter with respect to C++ conformance, and hence another piece of the changes necessary to let Lcalc build with Clang (cf. #12437) is needed for g++ as well, namely forbidden default parameters in function definitions ("Part II").

This also affects the Sage library, i.e., extension modules using Lcalc's headers won't build either (but fixing the Lcalc package also fixes that). Note that distutils ignore CXXFLAGS, so -fpermissive has to be passed in CFLAGS (for these modules) until Lcalc gets fixed.

The patch is trivial though.

Change History (7)

comment:1 Changed 6 years ago by leif

  • Authors set to Leif Leonhardy
  • Branch set to u/leif/Lcalc_GCC_5.x
  • Commit set to 8eaa4612f9d59837e7ce84e2e3cd44be0d49b939
  • Status changed from new to needs_review

New commits:

8eaa461Add patch to let Lcalc build with GCC 5.x (C++ issue, #18316)

comment:2 Changed 6 years ago by leif

P.S.: The declarations of the functions (still) contain exactly the same default parameters, so omitting them in their definitions doesn't break any code using the headers.

comment:3 follow-up: Changed 6 years ago by jdemeyer

  • Status changed from needs_review to needs_work

I think the patchlevel of the lcalc package needs to be increased (in case somebody upgrades GCC, you really want lcalc to be rebuilt).

comment:4 Changed 6 years ago by git

  • Commit changed from 8eaa4612f9d59837e7ce84e2e3cd44be0d49b939 to dddef7fb2eb10c0ba472ee7087d33dd49c4e7acc

Branch pushed to git repo; I updated commit sha1. New commits:

dddef7fBump patch level of Lcalc package (to 1.23.p14; #18316)

comment:5 in reply to: ↑ 3 Changed 6 years ago by leif

  • Status changed from needs_work to needs_review

Replying to jdemeyer:

I think the patchlevel of the lcalc package needs to be increased

Amen. ($OTHERS don't care much with the new workflowTM.)

(in case somebody upgrades GCC, you really want lcalc to be rebuilt).

Not me, but probably $SOMEBODY.

comment:6 Changed 6 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:7 Changed 6 years ago by vbraun

  • Branch changed from u/leif/Lcalc_GCC_5.x to dddef7fb2eb10c0ba472ee7087d33dd49c4e7acc
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.