Changes between Initial Version and Version 1 of Ticket #18310, comment 7


Ignore:
Timestamp:
05/16/15 22:23:25 (7 years ago)
Author:
tscrim
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18310, comment 7

    initial v1  
    1 Looks good overall. This was something Darij and I wondered about when looking at Lie algebras (something I will need to change on that ticket). However I have a question about the `column` attribute in `FDModWithBasis.ParentMethods.matrix`. You currently have `assert not columns` in the method. Did you want that to be a `NotImplementedError`, or did you want to have that do something in this ticket?
     1Looks good overall; I made some minor doc formatting tweaks. This was something Darij and I wondered about when looking at Lie algebras (something I will need to change on that ticket). However I have a question about the `column` attribute in `FDModWithBasis.ParentMethods.matrix`. You currently have `assert not columns` in the method. Did you want that to be a `NotImplementedError`, or did you want to have that do something in this ticket?
    22----
    33New commits: