Opened 8 years ago

Closed 8 years ago

#18307 closed defect (fixed)

cleanup of hyperbolic geodesic

Reported by: Frédéric Chapoton Owned by:
Priority: major Milestone: sage-6.7
Component: graphics Keywords: hyperbolic
Cc: Travis Scrimshaw, Vincent Delecroix Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: cc64f71 (Commits, GitHub, GitLab) Commit: cc64f713e772abc5cd10916abba548bb3149f1ce
Dependencies: Stopgaps:

Status badges

Description

Hyperbolic geodesics were buggy and using parametric curves.

Let us correct that and use the arc function.

Change History (5)

comment:1 Changed 8 years ago by Frédéric Chapoton

Branch: u/chapoton/18307
Commit: a95d2266609fc1a44556cd7942e68478d738a90c
Status: newneeds_review

New commits:

a95d226trac #18XXX clean-up of hyperbolic plane geodesics

comment:2 Changed 8 years ago by git

Commit: a95d2266609fc1a44556cd7942e68478d738a90ccc64f713e772abc5cd10916abba548bb3149f1ce

Branch pushed to git repo; I updated commit sha1. New commits:

cc64f71trac #18307 a doc typo in arc.py

comment:3 Changed 8 years ago by Frédéric Chapoton

Cc: Travis Scrimshaw Vincent Delecroix added

comment:4 Changed 8 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

LGTM.

comment:5 Changed 8 years ago by Volker Braun

Branch: u/chapoton/18307cc64f713e772abc5cd10916abba548bb3149f1ce
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.