Opened 7 years ago

Closed 7 years ago

#18307 closed defect (fixed)

cleanup of hyperbolic geodesic

Reported by: chapoton Owned by:
Priority: major Milestone: sage-6.7
Component: graphics Keywords: hyperbolic
Cc: tscrim, vdelecroix Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: cc64f71 (Commits, GitHub, GitLab) Commit: cc64f713e772abc5cd10916abba548bb3149f1ce
Dependencies: Stopgaps:

Status badges

Description

Hyperbolic geodesics were buggy and using parametric curves.

Let us correct that and use the arc function.

Change History (5)

comment:1 Changed 7 years ago by chapoton

  • Branch set to u/chapoton/18307
  • Commit set to a95d2266609fc1a44556cd7942e68478d738a90c
  • Status changed from new to needs_review

New commits:

a95d226trac #18XXX clean-up of hyperbolic plane geodesics

comment:2 Changed 7 years ago by git

  • Commit changed from a95d2266609fc1a44556cd7942e68478d738a90c to cc64f713e772abc5cd10916abba548bb3149f1ce

Branch pushed to git repo; I updated commit sha1. New commits:

cc64f71trac #18307 a doc typo in arc.py

comment:3 Changed 7 years ago by chapoton

  • Cc tscrim vdelecroix added

comment:4 Changed 7 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:5 Changed 7 years ago by vbraun

  • Branch changed from u/chapoton/18307 to cc64f713e772abc5cd10916abba548bb3149f1ce
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.