Opened 6 years ago
Closed 6 years ago
#18296 closed defect (fixed)
Emphasize that Graph.subgraph_search ignores edge labels
Reported by:  ncohen  Owned by:  

Priority:  major  Milestone:  sage6.7 
Component:  graph theory  Keywords:  
Cc:  tmonteil, vdelecroix, dcoudert  Merged in:  
Authors:  Nathann Cohen  Reviewers:  David Coudert 
Report Upstream:  N/A  Work issues:  
Branch:  87d0324 (Commits, GitHub, GitLab)  Commit:  87d03249071edf4b2907304f77093c8cd8849f0b 
Dependencies:  Stopgaps: 
Description (last modified by )
A post on sagesupport [1] reported that the subgraph_search
functions ignored edge labels, while the doc apparently claims the opposite.
Indeed, the common terminology of "labelled copies" and "unlabelled copies" is pretty misleading with respect to actual labels on the edge/vertices of the graph. With this branch, I hope to make this mistake less likely.
Nathann
[1] https://groups.google.com/d/topic/sagesupport/CTeSnBZN7Sc/discussion
Change History (11)
comment:1 Changed 6 years ago by
 Branch set to public/18296
 Commit set to 52ccff914d2f9e7836ab8cd36afe60724734e8b3
 Status changed from new to needs_review
comment:2 Changed 6 years ago by
 Description modified (diff)
comment:3 Changed 6 years ago by
 Status changed from needs_review to needs_work
aglgorithm
> algorithm
otherwise, the patch seems OK
comment:4 Changed 6 years ago by
 Commit changed from 52ccff914d2f9e7836ab8cd36afe60724734e8b3 to 4c944996e14eee4b5abb07e5f1f42124a3695ab6
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
4c94499  trac #18296: Emphasize that Graph.subgraph_search ignores edge labels

comment:5 Changed 6 years ago by
 Status changed from needs_work to needs_review
comment:6 Changed 6 years ago by
 Reviewers set to David Coudert
 Status changed from needs_review to positive_review
For me the patch is good to go (install, doctest, docbuild, etc.). David.
comment:7 Changed 6 years ago by
Thanks !
comment:9 Changed 6 years ago by
 Commit changed from 4c944996e14eee4b5abb07e5f1f42124a3695ab6 to 87d03249071edf4b2907304f77093c8cd8849f0b
comment:10 Changed 6 years ago by
 Status changed from needs_work to positive_review
I don't see how it was caused by this branch, but indeed there is a mistake O_o
comment:11 Changed 6 years ago by
 Branch changed from public/18296 to 87d03249071edf4b2907304f77093c8cd8849f0b
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
trac #18296: Emphasize that Graph.subgraph_search ignores edge labels