Opened 5 years ago

Closed 5 years ago

#18295 closed enhancement (fixed)

random SSYT

Reported by: deinst Owned by: deinst
Priority: minor Milestone: sage-6.7
Component: combinatorics Keywords:
Cc: Merged in:
Authors: David Einstein Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 30d332c (Commits) Commit: 30d332c24f20e212ad02bf6592690a6528e99bae
Dependencies: Stopgaps:

Description (last modified by deinst)

Efficient algorithms exist to generate uniformly distributed random SSYT with a given shape or size paralleling the random_element methods for standard young tableaux.

Change History (8)

comment:1 Changed 5 years ago by deinst

  • Authors set to David Einstein
  • Component changed from PLEASE CHANGE to combinatorics
  • Owner changed from (none) to deinst
  • Priority changed from major to minor
  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 5 years ago by deinst

  • Branch set to u/deinst/random_ssyt

comment:3 Changed 5 years ago by deinst

  • Branch u/deinst/random_ssyt deleted
  • Description modified (diff)
  • Status changed from new to needs_review

comment:4 Changed 5 years ago by deinst

  • Branch set to u/deinst/random_ssyt

comment:5 Changed 5 years ago by tscrim

  • Commit set to 71db228b662f07cd424ebdd5c11e4b8d019fc0c1
  • Reviewers set to Travis Scrimshaw

One bigger thing is that it seems like the description of the SemistandardTableaux(6, max_entry=7).random_element() was cutoff. Some smaller things:

  • Instead of code formatting, use the link: :class:`SemistandardTableau`.
  • The \t is interpreted by python/sphinx as a tab character. To work around this, make the string a so-called "raw" string, start the docstring by r""".
  • The first sentence should be declarative: Return instead of Returns.
  • In python, you don't need the parenthesis here: while (randpos >= tot):.
  • Make max_entry in code formatting: ``max_entry``.
  • Link to references by adding a trailing underscore: [Krat99]_.
  • Could you make sure there's no trailing whitespace?

Looks good otherwise. Thanks.


New commits:

c089c09Added random element functions to Semistandard Tableaux
71db228Merge branch 'random_ssyt' into t/18295/random_ssyt

comment:6 Changed 5 years ago by git

  • Commit changed from 71db228b662f07cd424ebdd5c11e4b8d019fc0c1 to 9701c1aa4b8ba110229da182fa6352c827b6168b

Branch pushed to git repo; I updated commit sha1. New commits:

9701c1aFixed truncated docstring

comment:7 Changed 5 years ago by tscrim

  • Branch changed from u/deinst/random_ssyt to u/tscrim/random_ssyt-18295
  • Commit changed from 9701c1aa4b8ba110229da182fa6352c827b6168b to 30d332c24f20e212ad02bf6592690a6528e99bae
  • Status changed from needs_review to positive_review

I rebased on the latest beta and made some trivial changes, so I'm setting this to positive review. Thanks for implementing this.


New commits:

e11e1e4Merge branch 'u/deinst/random_ssyt' of trac.sagemath.org:sage into u/tscrim/random_ssyt-18295
30d332cMarking tests as random.

comment:8 Changed 5 years ago by vbraun

  • Branch changed from u/tscrim/random_ssyt-18295 to 30d332c24f20e212ad02bf6592690a6528e99bae
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.