Opened 7 years ago

Closed 7 years ago

#18276 closed enhancement (fixed)

is_squarefree() should not restrict to PID's

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.7
Component: commutative algebra Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Bruno Grenet
Report Upstream: N/A Work issues:
Branch: e652a09 (Commits, GitHub, GitLab) Commit: e652a098c9d87cf7ec2e78e676ef47f1050aa3c3
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

The implementation of is_squarefree() for univariate polynomials requires that the base ring is a PID. However, mathematically, the question makes sense over any integral domain. Therefore, the condition on the input can be relaxed.

The algorithm relies on gcd(), so the gcd() can still raise an exception.

I don't know of any non-PID R in Sage for which the gcd in R[x] works, so this won't change anything in practice.

Change History (5)

comment:1 Changed 7 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from is_squarefree() should work over UFD, not just PID to is_squarefree() should not restrict to PID's

comment:2 Changed 7 years ago by jdemeyer

  • Branch set to u/jdemeyer/is_squarefree___should_work_over_ufd__not_just_pid

comment:3 Changed 7 years ago by jdemeyer

  • Commit set to e652a098c9d87cf7ec2e78e676ef47f1050aa3c3
  • Status changed from new to needs_review

New commits:

e652a09Remove PID restriction for polynomial is_squarefree()

comment:4 Changed 7 years ago by bruno

  • Reviewers set to Bruno Grenet
  • Status changed from needs_review to positive_review

LGTM!

comment:5 Changed 7 years ago by vbraun

  • Branch changed from u/jdemeyer/is_squarefree___should_work_over_ufd__not_just_pid to e652a098c9d87cf7ec2e78e676ef47f1050aa3c3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.