Opened 7 years ago

Closed 7 years ago

#18227 closed enhancement (fixed)

Finite state machines: some cleanup and code rewriting

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-6.9
Component: finite state machines Keywords: sd67
Cc: cheuberg, skropf Merged in:
Authors: Daniel Krenn Reviewers: Clemens Heuberger
Report Upstream: N/A Work issues:
Branch: e2083ef (Commits, GitHub, GitLab) Commit: e2083efb7492df13d54628e73204fb48f3025215
Dependencies: #15267, #18118, #18123, #19207, #19201, #18966, #19204, #19205, #19199, #19206, #18123 Stopgaps:

Status badges

Description

Some cleanup and rewritings to make the code even more readable (after talks at the PyCon2015+SageDays67).

Change History (15)

comment:1 Changed 7 years ago by dkrenn

  • Branch set to u/dkrenn/fsm/cleanup-and-readability

comment:2 Changed 7 years ago by dkrenn

  • Authors set to Daniel Krenn
  • Branch u/dkrenn/fsm/cleanup-and-readability deleted
  • Dependencies set to #15267
  • Status changed from new to needs_review

comment:3 Changed 7 years ago by cheuberg

  • Status changed from needs_review to needs_work

No branch is currently attached.

comment:4 Changed 7 years ago by dkrenn

  • Branch set to u/dkrenn/fsm/cleanup-and-readability

comment:5 Changed 7 years ago by dkrenn

  • Commit set to 3842477011919b502a5e7e299138af7927dfd435
  • Status changed from needs_work to needs_review

Ok, let's try this once again :)


Last 10 new commits:

8bd4296Merge branch 't/18114/fsm/automaton-to-transducer' into t/15267/fsm/languages
5d59d90adapt code after merge to pass doctests
416ec85SR.symbol --> SR.var
8fc08a5refactor imports from copy
768280arefactor imports (split up and use imports in methods; make everything more constitent)
17a4710make 2 empty lines above function/method definition everywhere
973a611namedtuple for a finished branch
dd05759add and use named tuple for currently processed branches
e722940use named tuple "branch" where possible
3842477fix some PEP8 and spacings

comment:6 Changed 7 years ago by cheuberg

  • Status changed from needs_review to needs_work

There is a merge conflict with #18084 which has been merged in 6.7.beta0.

comment:7 Changed 7 years ago by dkrenn

  • Dependencies changed from #15267 to #15267, #18118, #18123

comment:8 Changed 7 years ago by git

  • Commit changed from 3842477011919b502a5e7e299138af7927dfd435 to fb16681dba7295f47759cb9c6b6098e0c90a47ed

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

80d8798rename write_in_every_step and rephrase doc
7c9a164rephrase/extend doc of process_iterator_class
b580917Merge remote-tracking branch 'origin/u/dkrenn/fsm/languages' into fsm/words
da369d0#18123 comment 10, bullet 1: sentence deleted.
c02c375#18123 comment 10, bullet 2: delete unnecessary check
2301c1aTrac #18123 comment 10, bullet 3, 4, 6, 7: remove automatic_output_type=None
64ee3e8Trac #18123 comment 10, bullet 5: add additional doctests
e23bad3Merge remote-tracking branch 'trac/u/dkrenn/fsm/words' into t/18227/fsm/cleanup-and-readability
a579bf2fix doctests (imports and named_tuple)
fb16681repair previous merges

comment:9 Changed 7 years ago by dkrenn

  • Status changed from needs_work to needs_review

comment:10 Changed 7 years ago by dkrenn

  • Dependencies changed from #15267, #18118, #18123 to #15267, #18118, #18123, #19207, #19201, #18966, #19204, #19205, #19199, #19206, #18123
  • Status changed from needs_review to needs_work

comment:11 Changed 7 years ago by git

  • Commit changed from fb16681dba7295f47759cb9c6b6098e0c90a47ed to 5abaf8d4e491f9e0250ee6594501bbe82ad8e85c

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

3c0cc51rename: automata.word --> automata.Word
efec6a0Merge branch 'fsm/upper-case-generator-word' into t/18227/fsm/cleanup-and-readability
73588a6update copyright and authors
2255065restructure imports: add_varargs
d0acfa7rewrite functools.reduce to use sum instead
8d7d501change links from :mod: to :doc:
ae0a9a4link examples
4fe28bblink the automata and transducers objects
0e71576minor rewrite of generators class description of
5abaf8drewrite top docstring of module

comment:12 Changed 7 years ago by git

  • Commit changed from 5abaf8d4e491f9e0250ee6594501bbe82ad8e85c to e2083efb7492df13d54628e73204fb48f3025215

Branch pushed to git repo; I updated commit sha1. New commits:

df997f1fix broken links
cab6fccTrac #19210: replace three more occurrences word->Word
e2083efMerge branch 'u/cheuberg/fsm/upper-case-generator-word' of trac.sagemath.org:sage into t/18227/fsm/cleanup-and-readability

comment:13 Changed 7 years ago by dkrenn

  • Status changed from needs_work to needs_review

comment:14 Changed 7 years ago by cheuberg

  • Milestone changed from sage-6.7 to sage-6.9
  • Reviewers set to Clemens Heuberger
  • Status changed from needs_review to positive_review

seems to be fine; doctests pass, documentation builds.

comment:15 Changed 7 years ago by vbraun

  • Branch changed from u/dkrenn/fsm/cleanup-and-readability to e2083efb7492df13d54628e73204fb48f3025215
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.