Opened 7 years ago

Closed 7 years ago

#18200 closed enhancement (fixed)

Caching canonical_label in IncidenceStructure.is_isomorphic

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.7
Component: combinatorial designs Keywords:
Cc: vdelecroix Merged in:
Authors: Nathann Cohen Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 75326b0 (Commits, GitHub, GitLab) Commit: 75326b0d7ee662a238d8f38fc4a2e14e763cdf36
Dependencies: Stopgaps:

Status badges

Description

As we compute the information anyway, let us cache it.

Nathann

Change History (9)

comment:1 Changed 7 years ago by ncohen

  • Branch set to public/18200
  • Status changed from new to needs_review

comment:2 Changed 7 years ago by git

  • Commit set to 668a71e352c30c5db87d2e8c08db630213574132

Branch pushed to git repo; I updated commit sha1. New commits:

668a71etrac #18200: Caching canonical_label in IncidenceStructure.is_isomorphic

comment:3 Changed 7 years ago by vdelecroix

Would you remove

.. NOTE::

    If you need to test isomorphisms between one incidence
    structure and many others, you should consider using
    :meth:`canonical_label` instead of this function.

in the documentation of is_isomorphic?

comment:4 Changed 7 years ago by ncohen

O_o

Yes of course!

comment:5 Changed 7 years ago by git

  • Commit changed from 668a71e352c30c5db87d2e8c08db630213574132 to 75326b0d7ee662a238d8f38fc4a2e14e763cdf36

Branch pushed to git repo; I updated commit sha1. New commits:

75326b0trac #18200: Review

comment:6 Changed 7 years ago by ncohen

Wow. Delay between your comment and my commit: 70 seconds :-P

comment:7 Changed 7 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to positive_review

Much more natural to use now!

comment:8 Changed 7 years ago by ncohen

My only regret is that I cannot be too harsh on the idiot that copied the structure BEFORE computing the canonical label, yet thought about adding this warning.

Idiots.

Nathann

comment:9 Changed 7 years ago by vbraun

  • Branch changed from public/18200 to 75326b0d7ee662a238d8f38fc4a2e14e763cdf36
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.