Opened 7 years ago

Closed 7 years ago

#18189 closed defect (fixed)

real_roots.root_bounds: Inconsistent return types

Reported by: Marc Mezzarobba Owned by:
Priority: minor Milestone: sage-6.7
Component: algebra Keywords:
Cc: Merged in:
Authors: Marc Mezzarobba Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: b83cfe4 (Commits, GitHub, GitLab) Commit: b83cfe497195fe7298cb37e9c227c0e63f8c90fd
Dependencies: Stopgaps:

Status badges

Description (last modified by Marc Mezzarobba)

sage: import sage.rings.polynomial.real_roots as rr
sage: x = polygen(QQ)
sage: rr.root_bounds(x)
(0, 0)
sage: rr.root_bounds(x+1)
(-1.00000000000000, -1.00000000000000)
sage: rr.cl_maximum_root_first_lambda([RIF(-1), RIF(0), RIF(1)]).parent()
Real Field with 53 bits of precision and rounding RNDU
sage: type(rr.cl_maximum_root_first_lambda(map(RIF, [0, 0, 0, 14, 1])))
<type 'int'>

Change History (5)

comment:1 Changed 7 years ago by Marc Mezzarobba

Authors: Marc Mezzarobba
Branch: u/mmezzarobba/18189-root_bounds
Commit: d646e31eab13f470c3103db1d7072ca7c2781918
Description: modified (diff)
Status: newneeds_review
Summary: real_roots.cl_maximum_root_first_lambda: Inconsistent return typesreal_roots.root_bounds: Inconsistent return types

New commits:

d646e31#18189 fix return type of real_roots.root_bounds...

comment:2 Changed 7 years ago by git

Commit: d646e31eab13f470c3103db1d7072ca7c2781918b83cfe497195fe7298cb37e9c227c0e63f8c90fd

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

b83cfe4#18189 fix return type of real_roots.root_bounds...

comment:3 Changed 7 years ago by Vincent Delecroix

Reviewers: Vincent Delecroix
Status: needs_reviewpositive_review

comment:4 Changed 7 years ago by Vincent Delecroix

Milestone: sage-6.6sage-6.7

comment:5 Changed 7 years ago by Volker Braun

Branch: u/mmezzarobba/18189-root_boundsb83cfe497195fe7298cb37e9c227c0e63f8c90fd
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.