Opened 8 years ago

Closed 8 years ago

#18169 closed defect (fixed)

Ref: add various missing modules to r/*rings*

Reported by: mmezzarobba Owned by:
Priority: minor Milestone: sage-6.6
Component: documentation Keywords:
Cc: Merged in:
Authors: Marc Mezzarobba Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 54df1d6 (Commits, GitHub, GitLab) Commit: 54df1d660551ce5840d3ceefd79ba3a7fbe890bd
Dependencies: Stopgaps:

Status badges

Description (last modified by vdelecroix)

Many files in sage/rings/* are not in the documentation!

follow up: #18300

Change History (14)

comment:1 Changed 8 years ago by mmezzarobba

Branch: u/mmezzarobba/ref-rings

comment:2 Changed 8 years ago by mmezzarobba

Authors: Marc Mezzarobba
Commit: 9ce70d7a77b7fc7306ca631437e016a889396adc
Component: PLEASE CHANGEdocumentation
Priority: majorminor
Status: newneeds_review
Type: PLEASE CHANGEdefect

New commits:

827913epolynomial_compiled: rst fixes
760a5a1number_field.totallyreal_*: rst fixes
6ffc7d9sage.rings.bern*: rst fixes
9ce70d7Ref: add various missing modules to r/*rings*

comment:3 Changed 8 years ago by git

Commit: 9ce70d7a77b7fc7306ca631437e016a889396adc3491f5802ccb9a71f5e0c2a3db2b3ebc164c08b1

Branch pushed to git repo; I updated commit sha1. New commits:

30599c4games.hexad: rst fixes
a3261b8sandpiles.sandpiles: rst fixes
ca7ac34matroids_plot_helpers: rst fixes
087cabcmodform.theta: rst fixes
f736624cunningham_tables: rst fixes
1df5afbmonoids.strings_ops: rst fixes
6858c7fstats.r: rst fixes
558761dRef: remove duplicate entry in r/algebras
2ceb598Ref: add missing modules to various parts of the manual
3491f58Merge branch 'ref-others' into ref-rings

comment:4 Changed 8 years ago by mmezzarobba

Dependencies: 18170
Last edited 8 years ago by mmezzarobba (previous) (diff)

comment:5 Changed 8 years ago by mmezzarobba

Dependencies: 18170#18170

comment:6 Changed 8 years ago by mmezzarobba

Dependencies: #18170
Status: needs_reviewneeds_work

comment:7 Changed 8 years ago by git

Commit: 3491f5802ccb9a71f5e0c2a3db2b3ebc164c08b154df1d660551ce5840d3ceefd79ba3a7fbe890bd

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

cf23812polynomial_compiled: rst fixes
f7c0fa2number_field.totallyreal_*: rst fixes
9ed1b17sage.rings.bern*: rst fixes
54df1d6Ref: add various missing modules to r/*rings*

comment:8 Changed 8 years ago by mmezzarobba

Status: needs_workneeds_review

comment:9 Changed 8 years ago by vdelecroix

Branch: u/mmezzarobba/ref-ringspublic/18169
Commit: 54df1d660551ce5840d3ceefd79ba3a7fbe890bdd8783860a2accc20bb335dd36b9862a9fd5c94c5
Status: needs_reviewneeds_info

Approximately all modules cite Cohen's book. But each of them has its own reference!

In the main index, there is a section Number Theory, Algebraic Geometry. But many modules that you added are in rings (like sage/rings/bernmm, sage/rings/bernoulli_mod_p, sage/rings/contfrac, sage/rings/factorint, sage/rings/fast_arith).

I did some changes and cleaning in number fields. Tell me if you like. I can also try to reorganise the ring section.

Vincent


New commits:

d878386Tiny documentation modifications for number fields

comment:10 Changed 8 years ago by mmezzarobba

I really would prefer to keep these improvements for another ticket, in order to keep the current “add missing modules...” tickets independent of each other. It will be much easier to make changes that span several of them once all modules that need to appear in the reference manual appear somewhere!

comment:11 Changed 8 years ago by vdelecroix

Branch: public/18169u/mmezzarobba/ref-rings
Commit: d8783860a2accc20bb335dd36b9862a9fd5c94c554df1d660551ce5840d3ceefd79ba3a7fbe890bd
Reviewers: Vincent Delecroix
Status: needs_infopositive_review

Then it is good to go as the documentation builds! I will open a ticket for number fields with my commit.

comment:12 in reply to:  11 Changed 8 years ago by mmezzarobba

Replying to vdelecroix:

Then it is good to go as the documentation builds! I will open a ticket for number fields with my commit.

Thanks! Please Cc: me on the new ticket.

comment:13 Changed 8 years ago by vdelecroix

Description: modified (diff)

I did, for the other readers it is #18300.

comment:14 Changed 8 years ago by vbraun

Branch: u/mmezzarobba/ref-rings54df1d660551ce5840d3ceefd79ba3a7fbe890bd
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.