Opened 8 years ago
Closed 8 years ago
#18169 closed defect (fixed)
Ref: add various missing modules to r/*rings*
Reported by:  mmezzarobba  Owned by:  

Priority:  minor  Milestone:  sage6.6 
Component:  documentation  Keywords:  
Cc:  Merged in:  
Authors:  Marc Mezzarobba  Reviewers:  Vincent Delecroix 
Report Upstream:  N/A  Work issues:  
Branch:  54df1d6 (Commits, GitHub, GitLab)  Commit:  54df1d660551ce5840d3ceefd79ba3a7fbe890bd 
Dependencies:  Stopgaps: 
Description (last modified by )
Many files in sage/rings/*
are not in the documentation!
follow up: #18300
Change History (14)
comment:1 Changed 8 years ago by
Branch:  → u/mmezzarobba/refrings 

comment:2 Changed 8 years ago by
Authors:  → Marc Mezzarobba 

Commit:  → 9ce70d7a77b7fc7306ca631437e016a889396adc 
Component:  PLEASE CHANGE → documentation 
Priority:  major → minor 
Status:  new → needs_review 
Type:  PLEASE CHANGE → defect 
comment:3 Changed 8 years ago by
Commit:  9ce70d7a77b7fc7306ca631437e016a889396adc → 3491f5802ccb9a71f5e0c2a3db2b3ebc164c08b1 

Branch pushed to git repo; I updated commit sha1. New commits:
30599c4  games.hexad: rst fixes

a3261b8  sandpiles.sandpiles: rst fixes

ca7ac34  matroids_plot_helpers: rst fixes

087cabc  modform.theta: rst fixes

f736624  cunningham_tables: rst fixes

1df5afb  monoids.strings_ops: rst fixes

6858c7f  stats.r: rst fixes

558761d  Ref: remove duplicate entry in r/algebras

2ceb598  Ref: add missing modules to various parts of the manual

3491f58  Merge branch 'refothers' into refrings

comment:5 Changed 8 years ago by
Dependencies:  18170 → #18170 

comment:6 Changed 8 years ago by
Dependencies:  #18170 

Status:  needs_review → needs_work 
comment:7 Changed 8 years ago by
Commit:  3491f5802ccb9a71f5e0c2a3db2b3ebc164c08b1 → 54df1d660551ce5840d3ceefd79ba3a7fbe890bd 

comment:8 Changed 8 years ago by
Status:  needs_work → needs_review 

comment:9 Changed 8 years ago by
Branch:  u/mmezzarobba/refrings → public/18169 

Commit:  54df1d660551ce5840d3ceefd79ba3a7fbe890bd → d8783860a2accc20bb335dd36b9862a9fd5c94c5 
Status:  needs_review → needs_info 
Approximately all modules cite Cohen's book. But each of them has its own reference!
In the main index, there is a section Number Theory, Algebraic Geometry
. But many modules that you added are in rings
(like sage/rings/bernmm
, sage/rings/bernoulli_mod_p
, sage/rings/contfrac
, sage/rings/factorint
, sage/rings/fast_arith
).
I did some changes and cleaning in number fields. Tell me if you like. I can also try to reorganise the ring section.
Vincent
New commits:
d878386  Tiny documentation modifications for number fields

comment:10 Changed 8 years ago by
I really would prefer to keep these improvements for another ticket, in order to keep the current “add missing modules...” tickets independent of each other. It will be much easier to make changes that span several of them once all modules that need to appear in the reference manual appear somewhere!
comment:11 followup: 12 Changed 8 years ago by
Branch:  public/18169 → u/mmezzarobba/refrings 

Commit:  d8783860a2accc20bb335dd36b9862a9fd5c94c5 → 54df1d660551ce5840d3ceefd79ba3a7fbe890bd 
Reviewers:  → Vincent Delecroix 
Status:  needs_info → positive_review 
Then it is good to go as the documentation builds! I will open a ticket for number fields with my commit.
comment:12 Changed 8 years ago by
Replying to vdelecroix:
Then it is good to go as the documentation builds! I will open a ticket for number fields with my commit.
Thanks! Please Cc: me on the new ticket.
comment:13 Changed 8 years ago by
Description:  modified (diff) 

I did, for the other readers it is #18300.
comment:14 Changed 8 years ago by
Branch:  u/mmezzarobba/refrings → 54df1d660551ce5840d3ceefd79ba3a7fbe890bd 

Resolution:  → fixed 
Status:  positive_review → closed 
New commits:
polynomial_compiled: rst fixes
number_field.totallyreal_*: rst fixes
sage.rings.bern*: rst fixes
Ref: add various missing modules to r/*rings*