Opened 5 years ago

Closed 5 years ago

#18155 closed enhancement (duplicate)

upgrade to pynac-0.3.3

Reported by: rws Owned by: rws
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Benjamin Hackl
Report Upstream: Reported upstream. Developers acknowledge bug. Work issues:
Branch: 839c49f (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by rws)

Don't use attached files use https://drive.google.com/folderview?id=0B4PmRyK1JXgHfmJmbWZ5NnVtMnNITTVHQ2hCci1WVnhLbC1PeC1YbzRQLUpidU9yY0x3Qjg&usp=sharing

* fixed the series expansion of zeta(s) around 1
* print_latex of wildcards
* clear the libtool versioning scheme
* sync with current GiNaC as much as possible

Upgrade will require a few doctests to adapt, see https://groups.google.com/d/topic/sage-devel/hwQXxFmutcU/discussion

Dependent tickets: #15047, #15846

Attachments (2)

pynac-0.3.3.tar.bz2 (764.8 KB) - added by rws 5 years ago.
pynac-0.3.3.tar.2.bz2 (886.0 KB) - added by rws 5 years ago.
version without soft links

Download all attachments as: .zip

Change History (33)

comment:1 Changed 5 years ago by rws

  • Description modified (diff)
  • Owner changed from (none) to rws

comment:2 Changed 5 years ago by rws

  • Description modified (diff)

comment:3 Changed 5 years ago by rws

  • Branch set to u/rws/upgrade_to_pynac_0_3_3

Changed 5 years ago by rws

comment:4 Changed 5 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to 77b3ca5aff3e67f69371381a0852ebd7d5721c89
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

77b3ca518155: upgrade to pynac-0.3.3

comment:5 Changed 5 years ago by behackl

Starting build...
Running build_pynac...
configure: error: cannot find install-sh, install.sh, or shtool in "." "./.." "./../.."
make: *** No targets specified and no makefile found.  Stop.
Error building pynac.

real	0m0.073s
user	0m0.017s
sys	0m0.003s
************************************************************************
Error installing package pynac-0.3.3
************************************************************************

It seems that you linked, for example, install-sh -> /usr/share/automake-1.13/install-sh. I have automake-1.15 installed, thus install-sh cannot be found.

In Pynac 0.3.2, these files were actually included in the .tar.bz2, I think.

comment:6 Changed 5 years ago by behackl

  • Status changed from needs_review to needs_work

comment:7 Changed 5 years ago by rws

Ah, the h option of tar is needed.

comment:8 Changed 5 years ago by rws

  • Branch changed from u/rws/upgrade_to_pynac_0_3_3 to u/rws/18155-1

Changed 5 years ago by rws

version without soft links

comment:9 Changed 5 years ago by rws

  • Commit changed from 77b3ca5aff3e67f69371381a0852ebd7d5721c89 to 2db2621f9a89086ec1792a5ccc1748cc0e7c4761
  • Status changed from needs_work to needs_review

Now the attachment has the wrong name so you need to rename in your upstream/.


New commits:

2db262118155: upgrade to pynac-0.3.3

comment:10 Changed 5 years ago by behackl

  • Reviewers set to Benjamin Hackl
  • Status changed from needs_review to positive_review

Passes make ptestlong. Thanks for pushing a new version!

comment:11 Changed 5 years ago by rws

Thanks for the review!

Last edited 5 years ago by rws (previous) (diff)

comment:12 Changed 5 years ago by vbraun

Attaching larger files to trac isn't ideal, they are stored in the database forever. If you don't have a place to host files ask William for an account on boxen...

comment:13 follow-up: Changed 5 years ago by vbraun

The pynac-0.3.3.tar.bz2 file is apparently not the one you envisioned:

Attempting to download package pynac-0.3.3
>>> Trying to download http://www.sagemath.org/packages/upstream/pynac/pynac-0.3.3.tar.bz2
[............................................................]
Checksum: 76fea7a56a14d52eb2d14aaf11e21598bd68a8b4 vs 1afc858a8d18050604655b69096fcf13f42df73c

The file is now cached by all buildbots. Note that I can't possibly read all tickets that I'm merging. Can you change the tarball name.

comment:14 Changed 5 years ago by vbraun

  • Status changed from positive_review to needs_work

comment:15 Changed 5 years ago by behackl

... nevermind, took me a while to understand what shall be done here.

Last edited 5 years ago by behackl (previous) (diff)

comment:16 in reply to: ↑ 13 Changed 5 years ago by rws

Replying to vbraun:

The file is now cached by all buildbots. Note that I can't possibly read all tickets that I'm merging. Can you change the tarball name.

If I could have deleted my first attachment there wouldn't be a problem. I asked William for upload space today. You mean a different version string?

comment:17 Changed 5 years ago by fbissey

You know it doesn't have to be a tar.bz2. It is preferable for space reason but tar.gz works just as well, which means that you could have pointed to https://github.com/pynac/pynac/archive/pynac-0.3.3.tar.gz with the appropriate check sums.

Last edited 5 years ago by fbissey (previous) (diff)

comment:18 Changed 5 years ago by rws

  • Description modified (diff)
  • Status changed from needs_work to positive_review

Setting positive because only the cksums changed. Note the download link in the description.

comment:19 Changed 5 years ago by git

  • Commit changed from 2db2621f9a89086ec1792a5ccc1748cc0e7c4761 to 216e29c729ed2405d73a0d53e2a7d38da9a34ba8
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

216e29c18155: changed chksum for tarball made with make dist

comment:20 Changed 5 years ago by rws

  • Status changed from needs_review to positive_review

comment:21 Changed 5 years ago by vbraun

As I said before, pynac-0.3.3.tar.bz2 is now cached on the buildbots. You can either manually delete the cached copy on each build slave, or you rename the tarball (e.g. to pynac-0.3.3.tar.gz)

comment:22 Changed 5 years ago by git

  • Commit changed from 216e29c729ed2405d73a0d53e2a7d38da9a34ba8 to 839c49fbf7ae9a8917fda4ed326e7f58729a02b4
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

839c49f18155: file change

comment:23 Changed 5 years ago by rws

  • Status changed from needs_review to positive_review

comment:24 Changed 5 years ago by vbraun

  • Branch changed from u/rws/18155-1 to 839c49fbf7ae9a8917fda4ed326e7f58729a02b4
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:25 Changed 5 years ago by vbraun

  • Commit 839c49fbf7ae9a8917fda4ed326e7f58729a02b4 deleted
  • Resolution fixed deleted
  • Status changed from closed to new

On OSX:

sage -t --long src/doc/en/prep/Calculus.rst
**********************************************************************
File "src/doc/en/prep/Calculus.rst", line 396, in doc.en.prep.Calculus
Failed example:
    integral(h,(x,0,pi/8))
Expected:
    1/2*log(sin(1/8*pi) + 1) - 1/2*log(-sin(1/8*pi) + 1)
Got:
    -1/2*log(-sin(1/8*pi) + 1) + 1/2*log(sin(1/8*pi) + 1)
**********************************************************************
1 item had failures:
   1 of  58 in doc.en.prep.Calculus
    [57 tests, 1 failure, 27.74 s]

comment:26 Changed 5 years ago by behackl

This is strange. On Arch Linux, I have

sage -t --long --warn-long 81.6 src/doc/en/prep/Calculus.rst
    [57 tests, 11.79 s]
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------

and especially

sage: -1/2*log(-sin(1/8*pi) + 1) + 1/2*log(sin(1/8*pi) + 1)
1/2*log(sin(1/8*pi) + 1) - 1/2*log(-sin(1/8*pi) + 1)

Nothing changes in my results if I rebase this branch on top of sage-6.7.beta0.

Does anyone have an idea what could cause the change in the order of summands on OSX?

Last edited 5 years ago by behackl (previous) (diff)

comment:27 Changed 5 years ago by rws

  • Status changed from new to needs_info

comment:29 Changed 5 years ago by rws

  • Milestone changed from sage-6.6 to sage-pending
  • Report Upstream changed from N/A to Reported upstream. Developers acknowledge bug.

comment:30 Changed 5 years ago by rws

  • Milestone changed from sage-pending to sage-duplicate/invalid/wontfix
  • Status changed from needs_info to positive_review

This is now abandoned in favor of #18237. Please review that ticket.

comment:31 Changed 5 years ago by vbraun

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.