Rank of int matrix, documentation typo

[jmantysalo]

Output section of rank() contains input. Also Matrix.random(ZZ, 3).rank(algorithm='cat-says-meow') gives no error message.

[jmantysalo]

New commits:

​91cb99a

Fixed doc typo; added check for parameter 'algorithm'.

[vdelecroix]

I do not like this extra if. Could you rather change the code to:

if algorithm == 'flint':
    ...
elif algorithm == 'modp':
    ...
elif algorithm == 'linbox':
    ...
else:
    raise ValueError

[jmantysalo]

See the comment line

# Algorithm is 'linbox' or detecting full rank didn't work . . .

This can be done, but I think that it would make code a little unclear.

[jdemeyer]

What's with the changes in indendation?

[jmantysalo]

Replying to jdemeyer:

What's with the changes in indendation?

The line had 11 spaces. I have thinked that Python should have 4n spaces. It's not at all the only line like that, see

egrep '^ {4}* {1,3}[^ ]' src/sage/matrix/matrix_integer_dense.pyx

[jmantysalo]

If my explanation of spaces is good enought, maybe this can be closed?

[jdemeyer]

Replying to jmantysalo:

If my explanation of spaces is good enough

No, it's not good enough. I still don't understand why you are changing the indendation on some lines from correct to wrong (please look at the diff!)

[chapoton]

I have made a review commit. Thinks look good to me, but other reviewer should agree before this is set to positive review.

---

New commits:

​1c8490c	Merge branch 'u/jmantysalo/rank_of_int_matrix__documentation_typo' into 6.6.rc3
​fc49c4f	trac #18147 review commit