Opened 5 years ago

Closed 4 years ago

#18144 closed enhancement (fixed)

method surgroups for arithmetic group

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-6.6
Component: group theory Keywords:
Cc: davidloeffler Merged in:
Authors: Vincent Delecroix Reviewers: David Loeffler
Report Upstream: N/A Work issues:
Branch: 8a2506e (Commits) Commit: 8a2506e6260d0ae113e645da45c2d63dce0642f1
Dependencies: Stopgaps:

Description

Add a method .surgroups to ArithmeticSubgroup_permutation_class to list all intermediate subgroup between SL(2,Z) and the group.

Change History (6)

comment:1 Changed 5 years ago by vdelecroix

  • Branch set to u/vdelecroix/18144
  • Commit set to e2c8f10215d821e9e49848edab1b62117f27b445
  • Status changed from new to needs_review

New commits:

e2c8f10Trac 18144: surgroups for an arithmetic group

comment:2 Changed 5 years ago by git

  • Commit changed from e2c8f10215d821e9e49848edab1b62117f27b445 to 70c6c7e0d55ba1bee64c450c3d9edc1d22153052

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

70c6c7eTrac 18144: surgroups for an arithmetic group

comment:3 Changed 4 years ago by git

  • Commit changed from 70c6c7e0d55ba1bee64c450c3d9edc1d22153052 to 8a2506e6260d0ae113e645da45c2d63dce0642f1

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8a2506eTrac 18144: surgroups for arithmetic groups

comment:4 Changed 4 years ago by vdelecroix

rebased on sage-6.8.beta2


New commits:

8a2506eTrac 18144: surgroups for arithmetic groups

comment:5 Changed 4 years ago by davidloeffler

  • Reviewers set to David Loeffler
  • Status changed from needs_review to positive_review

Looks good to me. I would have called this an "overgroup" rather than a "surgroup", but it seems that both notations are common enough. It's possibly not ideal that so much general group-theoretic functionality is getting added to permutation arithmetic subgroups that isn't available from the top-level ArithmeticSubgroup classes, and thus might not be noticed by the average user, but that is an issue for another ticket.

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/vdelecroix/18144 to 8a2506e6260d0ae113e645da45c2d63dce0642f1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.