Opened 5 years ago

Closed 5 years ago

#18140 closed enhancement (fixed)

Remove some global imports from all.py files

Reported by: jdemeyer Owned by:
Priority: minor Milestone: sage-6.6
Component: misc Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Marc Mezzarobba
Report Upstream: N/A Work issues:
Branch: a0ce3e7 (Commits) Commit: a0ce3e7e53dd234569c26774bb6ce56ef53b3205
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

There is no point in doing

import sage.foo.bar

in an all.py file.

Moreover, we deprecate some globals which are whole modules.

Change History (8)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/18140

comment:2 Changed 5 years ago by jdemeyer

  • Commit set to 7dfc9604aecc5b487649489709df8db5f0047c5d
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

7dfc960Remove/deprecate some global imports

comment:3 Changed 5 years ago by mmezzarobba

  • Reviewers set to Marc Mezzarobba
  • Status changed from needs_review to positive_review

comment:4 Changed 5 years ago by vbraun

  • Status changed from positive_review to needs_work

Please merge with 6.7.beta0

comment:5 Changed 5 years ago by git

  • Commit changed from 7dfc9604aecc5b487649489709df8db5f0047c5d to a0ce3e7e53dd234569c26774bb6ce56ef53b3205

Branch pushed to git repo; I updated commit sha1. New commits:

a0ce3e7Merge tag '6.7.beta0' into t/18140/ticket/18140

comment:6 Changed 5 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:7 Changed 5 years ago by vbraun

  • Status changed from needs_review to positive_review

comment:8 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/18140 to a0ce3e7e53dd234569c26774bb6ce56ef53b3205
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.