Opened 4 years ago

Closed 4 years ago

#18108 closed enhancement (fixed)

Deprecate sage.rings.field

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.6
Component: commutative algebra Keywords: sd66
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Ralf Stephan
Report Upstream: N/A Work issues:
Branch: 8a84e75 (Commits) Commit: 8a84e75974b3f739beeb84bb7fab73e4dd913424
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

This module contains just one function which is used nowhere in the Sage library. Moreover, it's confusing that often Field is imported from sage.rings.field while it's actually defined in sage.rings.ring (in Cython, so Cython modules can take advantage of that!)

Change History (6)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/deprecate_sage_rings_field

comment:2 Changed 4 years ago by jdemeyer

  • Commit set to 8a84e75974b3f739beeb84bb7fab73e4dd913424
  • Keywords sd66 added
  • Status changed from new to needs_review

New commits:

8a84e75Deprecate sage.rings.field

comment:3 Changed 4 years ago by kcrisman

+        sage: import sage.rings.field
+        doctest:...: DeprecationWarning: the module sage.rings.field is deprecated and will be removed
+        See http://trac.sagemath.org/18108 for details.

So ... what are the details? (That is, there is no reason apparent in the message, but presumably there is one obvious to those who use this, just would be helpful to have it here.)

comment:4 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 4 years ago by rws

  • Reviewers set to Ralf Stephan
  • Status changed from needs_review to positive_review

Looking fine and simple. Passes all tests in http://patchbot.sagemath.org/log/18108/Ubuntu/14.04/i686/3.13.0-40-generic/arando/2015-04-03%2001:27:54%20+0100?short

Your arando patchbot run, however, again seems to have problems, modules are not found.

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/deprecate_sage_rings_field to 8a84e75974b3f739beeb84bb7fab73e4dd913424
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.