Opened 12 years ago
Closed 12 years ago
#1810 closed enhancement (fixed)
[with patch, positive review] refactoring to improve finite field reference manual
Reported by: | malb | Owned by: | tba |
---|---|---|---|
Priority: | major | Milestone: | sage-2.10.3 |
Component: | documentation | Keywords: | |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
The patch removes FiniteField_prime_modn
from finite_field.py
because it was odd that this implementation was the only showing up in the reference manual. Also, GF
is now defined in rings.all
rather than in rings.finite_field
to avoid that the documentation for it shows up twice. Finally, a more verbose description of the finite field module is given at the top of the finite_field.py
file and some doctests were added to FiniteField_prime_modn
.
Attachments (5)
Change History (11)
Changed 12 years ago by
comment:1 Changed 12 years ago by
comment:2 Changed 12 years ago by
I am rebasing right now. make test
is running and looking good. Then, I'm afraid I'll have to check if I can apply the patch against 2.10.3.alpha0.
comment:3 Changed 12 years ago by
- Summary changed from [with patch] refactoring to improve finite field reference manual to [with patch, needs review] refactoring to improve finite field reference manual
Add gfp.patch
on top of finite_field_refactor_doc.3.patch
, I forgot to hg add finite_field_prime_modn.py
Changed 12 years ago by
comment:4 Changed 12 years ago by
guava_fix.patch needs also to be applied after the other patches
comment:5 Changed 12 years ago by
- Summary changed from [with patch, needs review] refactoring to improve finite field reference manual to [with patch, positive review] refactoring to improve finite field reference manual
Applies cleanly to 2.10.3.alpha0 and passes tests for me.
To apply the patch, do the following,
1) Apply finite_field_refactor_doc.3.patch
2) Apply gfp.patch
3) hg add finite_field_prime_modn.py
4) Apply guava_fix.patch
comment:6 Changed 12 years ago by
- Resolution set to fixed
- Status changed from new to closed
Merged finite_field_refactor_doc.3.patch, gfp.patch and guava_fix.patch in Sage 2.10.3.rc1
I get the following on a clean 2.10.2 install: