Opened 5 years ago

Closed 5 years ago

#18087 closed enhancement (fixed)

Remove sig_on() from __dealloc__

Reported by: jdemeyer Owned by:
Priority: minor Milestone: sage-6.6
Component: cython Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Peter Bruin
Report Upstream: N/A Work issues:
Branch: c9dce18 (Commits) Commit: c9dce18385fd59755cbcced5f1804bf60b19df07
Dependencies: Stopgaps:

Description

Since __dealloc__ cannot raise exceptions, we should remove sig_on() statements.

Change History (4)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/remove_sig_on___from___dealloc__

comment:2 Changed 5 years ago by jdemeyer

  • Commit set to c9dce18385fd59755cbcced5f1804bf60b19df07
  • Status changed from new to needs_review

New commits:

c9dce18Remove sig_on() from __dealloc__

comment:3 Changed 5 years ago by pbruin

  • Reviewers set to Peter Bruin
  • Status changed from needs_review to positive_review

comment:4 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/remove_sig_on___from___dealloc__ to c9dce18385fd59755cbcced5f1804bf60b19df07
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.