Opened 8 years ago

Closed 8 years ago

#18087 closed enhancement (fixed)

Remove sig_on() from __dealloc__

Reported by: Jeroen Demeyer Owned by:
Priority: minor Milestone: sage-6.6
Component: cython Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Peter Bruin
Report Upstream: N/A Work issues:
Branch: c9dce18 (Commits, GitHub, GitLab) Commit: c9dce18385fd59755cbcced5f1804bf60b19df07
Dependencies: Stopgaps:

Status badges

Description

Since __dealloc__ cannot raise exceptions, we should remove sig_on() statements.

Change History (4)

comment:1 Changed 8 years ago by Jeroen Demeyer

Branch: u/jdemeyer/remove_sig_on___from___dealloc__

comment:2 Changed 8 years ago by Jeroen Demeyer

Commit: c9dce18385fd59755cbcced5f1804bf60b19df07
Status: newneeds_review

New commits:

c9dce18Remove sig_on() from __dealloc__

comment:3 Changed 8 years ago by Peter Bruin

Reviewers: Peter Bruin
Status: needs_reviewpositive_review

comment:4 Changed 8 years ago by Volker Braun

Branch: u/jdemeyer/remove_sig_on___from___dealloc__c9dce18385fd59755cbcced5f1804bf60b19df07
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.