Opened 8 years ago

Closed 14 months ago

#18056 closed enhancement (fixed)

remove src/sage/combinat/integer_list_old.py

Reported by: Nicolas M. Thiéry Owned by:
Priority: major Milestone: sage-9.5
Component: combinatorics Keywords:
Cc: Travis Scrimshaw, Samuel Lelièvre, gh-kliem Merged in:
Authors: Frédéric Chapoton Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: 2bd108b (Commits, GitHub, GitLab) Commit: 2bd108b56aec4bea04d1143f4e0710abf235679c
Dependencies: Stopgaps:

Status badges

Description (last modified by Frédéric Chapoton)

This file is unused and marked as "do not use" since 2009.

And IntegerListsLex is since a long time available from somewhere else.

sage.combinat.integer_list_old has long been replaced by sage.combinat.integer_lists. We remove it.

The original aim of this ticket was to cythonize sage.combinat.integer_list_old.IntegerListsLex which has been taken care of as the new sage.combinat.integer_lists.invlex.IntegerListsLex is already cythonized.

Change History (15)

comment:1 Changed 8 years ago by Jeroen Demeyer

Component: PLEASE CHANGEcombinatorics
Dependencies: 18055

Why does this ticket depend on #18055? I think it would be much better to reverse the dependency (i.e. #18055 should depend on this). Because improving the algorithm will be much easier once you can use Cython.

comment:2 Changed 8 years ago by Jeroen Demeyer

Description: modified (diff)

comment:3 in reply to:  1 ; Changed 8 years ago by Nicolas M. Thiéry

Replying to jdemeyer:

Why does this ticket depend on #18055? I think it would be much better to reverse the dependency (i.e. #18055 should depend on this). Because improving the algorithm will be much easier once you can use Cython.

Maybe this will become true the day where running an interactive debugger will be trivial in Cython and recompilation will be instantaneous. In the mean time, I really don't see why Cythonizing can possibly make it easier. Besides, it remains to be decided whether we should go for Cython or for an external library in, say C++. This decision will be better taken once we know exactly what the algorithm looks like.

comment:4 in reply to:  3 Changed 8 years ago by Jeroen Demeyer

Dependencies: #18055
Description: modified (diff)

comment:5 Changed 4 years ago by Vincent Delecroix

Status: newneeds_info

This is already cythonized... should we close this ticket?

comment:6 Changed 14 months ago by Frédéric Chapoton

Milestone: sage-6.6sage-duplicate/invalid/wontfix
Status: needs_infoneeds_review

comment:7 Changed 14 months ago by Frédéric Chapoton

Cc: Travis Scrimshaw Samuel Lelièvre gh-kliem added; Bryan Gillespie removed

comment:8 Changed 14 months ago by gh-kliem

There is from sage.combinat.integer_list_old import IntegerListsLex which isn't used anymore. Should this be deprecated?

comment:9 Changed 14 months ago by Frédéric Chapoton

Authors: Frédéric Chapoton
Branch: u/chapoton/18056
Commit: 2bd108b56aec4bea04d1143f4e0710abf235679c
Dependencies: #18055
Milestone: sage-duplicate/invalid/wontfixsage-9.5

I think one can remove that file. There is a note from 2009 saying "do not use" !


New commits:

2bd108bremoving src/sage/combinat/integer_list_old.py

comment:10 Changed 14 months ago by gh-kliem

Reviewers: Jonathan Kliem
Status: needs_reviewpositive_review

LGTM.

comment:11 Changed 14 months ago by Matthias Köppe

Title and description of this ticket should be adjusted

comment:12 Changed 14 months ago by gh-kliem

Description: modified (diff)
Summary: Cythonize IntegerListsLexRemove `integer_list_old`

comment:13 Changed 14 months ago by Frédéric Chapoton

Description: modified (diff)
Summary: Remove `integer_list_old`remove src/sage/combinat/integer_list_old.py

comment:14 Changed 14 months ago by Frédéric Chapoton

Description: modified (diff)

comment:15 Changed 14 months ago by Volker Braun

Branch: u/chapoton/180562bd108b56aec4bea04d1143f4e0710abf235679c
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.