Opened 7 years ago

Closed 4 months ago

#18056 closed enhancement (fixed)

remove src/sage/combinat/integer_list_old.py

Reported by: nthiery Owned by:
Priority: major Milestone: sage-9.5
Component: combinatorics Keywords:
Cc: tscrim, slelievre, gh-kliem Merged in:
Authors: Frédéric Chapoton Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: 2bd108b (Commits, GitHub, GitLab) Commit: 2bd108b56aec4bea04d1143f4e0710abf235679c
Dependencies: Stopgaps:

Status badges

Description (last modified by chapoton)

This file is unused and marked as "do not use" since 2009.

And IntegerListsLex is since a long time available from somewhere else.

sage.combinat.integer_list_old has long been replaced by sage.combinat.integer_lists. We remove it.

The original aim of this ticket was to cythonize sage.combinat.integer_list_old.IntegerListsLex which has been taken care of as the new sage.combinat.integer_lists.invlex.IntegerListsLex is already cythonized.

Change History (15)

comment:1 follow-up: Changed 7 years ago by jdemeyer

  • Component changed from PLEASE CHANGE to combinatorics
  • Dependencies 18055 deleted

Why does this ticket depend on #18055? I think it would be much better to reverse the dependency (i.e. #18055 should depend on this). Because improving the algorithm will be much easier once you can use Cython.

comment:2 Changed 7 years ago by jdemeyer

  • Description modified (diff)

comment:3 in reply to: ↑ 1 ; follow-up: Changed 7 years ago by nthiery

Replying to jdemeyer:

Why does this ticket depend on #18055? I think it would be much better to reverse the dependency (i.e. #18055 should depend on this). Because improving the algorithm will be much easier once you can use Cython.

Maybe this will become true the day where running an interactive debugger will be trivial in Cython and recompilation will be instantaneous. In the mean time, I really don't see why Cythonizing can possibly make it easier. Besides, it remains to be decided whether we should go for Cython or for an external library in, say C++. This decision will be better taken once we know exactly what the algorithm looks like.

comment:4 in reply to: ↑ 3 Changed 7 years ago by jdemeyer

  • Dependencies set to #18055
  • Description modified (diff)

comment:5 Changed 3 years ago by vdelecroix

  • Status changed from new to needs_info

This is already cythonized... should we close this ticket?

comment:6 Changed 4 months ago by chapoton

  • Milestone changed from sage-6.6 to sage-duplicate/invalid/wontfix
  • Status changed from needs_info to needs_review

comment:7 Changed 4 months ago by chapoton

  • Cc tscrim slelievre gh-kliem added; bgillespie removed

comment:8 Changed 4 months ago by gh-kliem

There is from sage.combinat.integer_list_old import IntegerListsLex which isn't used anymore. Should this be deprecated?

comment:9 Changed 4 months ago by chapoton

  • Authors set to Frédéric Chapoton
  • Branch set to u/chapoton/18056
  • Commit set to 2bd108b56aec4bea04d1143f4e0710abf235679c
  • Dependencies #18055 deleted
  • Milestone changed from sage-duplicate/invalid/wontfix to sage-9.5

I think one can remove that file. There is a note from 2009 saying "do not use" !


New commits:

2bd108bremoving src/sage/combinat/integer_list_old.py

comment:10 Changed 4 months ago by gh-kliem

  • Reviewers set to Jonathan Kliem
  • Status changed from needs_review to positive_review

LGTM.

comment:11 Changed 4 months ago by mkoeppe

Title and description of this ticket should be adjusted

comment:12 Changed 4 months ago by gh-kliem

  • Description modified (diff)
  • Summary changed from Cythonize IntegerListsLex to Remove `integer_list_old`

comment:13 Changed 4 months ago by chapoton

  • Description modified (diff)
  • Summary changed from Remove `integer_list_old` to remove src/sage/combinat/integer_list_old.py

comment:14 Changed 4 months ago by chapoton

  • Description modified (diff)

comment:15 Changed 4 months ago by vbraun

  • Branch changed from u/chapoton/18056 to 2bd108b56aec4bea04d1143f4e0710abf235679c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.