Opened 6 years ago
Closed 6 years ago
#18054 closed enhancement (fixed)
Add is_finite method for the Symbolic Ring
Reported by:  bruno  Owned by:  

Priority:  major  Milestone:  sage6.6 
Component:  symbolics  Keywords:  is_finite symbolic_ring 
Cc:  Merged in:  
Authors:  Bruno Grenet  Reviewers:  Peter Bruin 
Report Upstream:  N/A  Work issues:  
Branch:  3378995 (Commits, GitHub, GitLab)  Commit:  33789954018a635295e906bccbb9d5c4f63fdeae 
Dependencies:  Stopgaps: 
Description
In this ticket, I add a method is_finite()
to the SymbolicRing
. The necessity for such a method occurs to me in #17840. Of course, the answer is False
.
Change History (7)
comment:1 Changed 6 years ago by
 Branch set to u/bruno/ticket/add_is_finite
comment:2 Changed 6 years ago by
 Commit set to 5dcebe40b5b28fdd248ce51e5598eab6e9c5a431
 Status changed from new to needs_review
comment:3 followup: ↓ 5 Changed 6 years ago by
 Reviewers set to Peter Bruin
 Status changed from needs_review to needs_work
comment:4 Changed 6 years ago by
 Commit changed from 5dcebe40b5b28fdd248ce51e5598eab6e9c5a431 to 33789954018a635295e906bccbb9d5c4f63fdeae
Branch pushed to git repo; I updated commit sha1. New commits:
3378995  Indentation

comment:5 in reply to: ↑ 3 Changed 6 years ago by
 Status changed from needs_work to needs_review
Replying to pbruin:
Looks good; the only comment I have is that the two lines inside the
EXAMPLES
block should be indented by 4 spaces.
Done!
comment:6 Changed 6 years ago by
 Status changed from needs_review to positive_review
comment:7 Changed 6 years ago by
 Branch changed from u/bruno/ticket/add_is_finite to 33789954018a635295e906bccbb9d5c4f63fdeae
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Looks good; the only comment I have is that the two lines inside the
EXAMPLES
block should be indented by 4 spaces.