Opened 8 years ago
Closed 7 years ago
#18054 closed enhancement (fixed)
Add is_finite method for the Symbolic Ring
Reported by:  Bruno Grenet  Owned by:  

Priority:  major  Milestone:  sage6.6 
Component:  symbolics  Keywords:  is_finite symbolic_ring 
Cc:  Merged in:  
Authors:  Bruno Grenet  Reviewers:  Peter Bruin 
Report Upstream:  N/A  Work issues:  
Branch:  3378995 (Commits, GitHub, GitLab)  Commit:  33789954018a635295e906bccbb9d5c4f63fdeae 
Dependencies:  Stopgaps: 
Description
In this ticket, I add a method is_finite()
to the SymbolicRing
. The necessity for such a method occurs to me in #17840. Of course, the answer is False
.
Change History (7)
comment:1 Changed 8 years ago by
Branch:  → u/bruno/ticket/add_is_finite 

comment:2 Changed 8 years ago by
Commit:  → 5dcebe40b5b28fdd248ce51e5598eab6e9c5a431 

Status:  new → needs_review 
comment:3 followup: 5 Changed 8 years ago by
Reviewers:  → Peter Bruin 

Status:  needs_review → needs_work 
comment:4 Changed 8 years ago by
Commit:  5dcebe40b5b28fdd248ce51e5598eab6e9c5a431 → 33789954018a635295e906bccbb9d5c4f63fdeae 

Branch pushed to git repo; I updated commit sha1. New commits:
3378995  Indentation

comment:5 Changed 8 years ago by
Status:  needs_work → needs_review 

Replying to pbruin:
Looks good; the only comment I have is that the two lines inside the
EXAMPLES
block should be indented by 4 spaces.
Done!
comment:6 Changed 8 years ago by
Status:  needs_review → positive_review 

comment:7 Changed 7 years ago by
Branch:  u/bruno/ticket/add_is_finite → 33789954018a635295e906bccbb9d5c4f63fdeae 

Resolution:  → fixed 
Status:  positive_review → closed 
Note: See
TracTickets for help on using
tickets.
Looks good; the only comment I have is that the two lines inside the
EXAMPLES
block should be indented by 4 spaces.