Opened 6 years ago

Closed 6 years ago

#18049 closed enhancement (fixed)

Compute class/modular polynomials using PARI

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.6
Component: number theory Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: b20b2b0 (Commits, GitHub, GitLab) Commit: b20b2b0a893f410b8bc1550b940cdffa34b0117e
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

PARI can quickly compute these polynomials, we no longer need to rely on database_kohel for this.

Change History (14)

comment:1 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Compute class polynomials using PARI to Compute class/modular polynomials using PARI

comment:2 Changed 6 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Dependencies set to #6311

comment:3 Changed 6 years ago by jdemeyer

  • Status changed from new to needs_review

comment:4 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/optional_doctest_failure____supersingular_j
  • Commit set to b20b2b0a893f410b8bc1550b940cdffa34b0117e

New commits:

009159dFix optional doctest
b20b2b0Use PARI to compute class and modular polynomials

comment:5 follow-up: Changed 6 years ago by vdelecroix

I really like the name of your branch ;-)

comment:6 follow-up: Changed 6 years ago by vdelecroix

Why is the following in commit b20b2b0

--- a/build/pkgs/pari/package-version.txt
+++ b/build/pkgs/pari/package-version.txt
@@ -1 +1 @@
-2.8-1369-g0e48e9b
+2.8-1369-g0e48e9b.p0

comment:7 in reply to: ↑ 6 ; follow-up: Changed 6 years ago by jdemeyer

Replying to vdelecroix:

Why is the following in commit b20b2b0

--- a/build/pkgs/pari/package-version.txt
+++ b/build/pkgs/pari/package-version.txt
@@ -1 +1 @@
-2.8-1369-g0e48e9b
+2.8-1369-g0e48e9b.p0

To force a rebuild of auto_gen.pxi, see 9:ticket:17860

comment:8 in reply to: ↑ 5 Changed 6 years ago by jdemeyer

Replying to vdelecroix:

I really like the name of your branch ;-)

I started out as a branch for #6311, but then I realized that the test didn't need to be optional at all.

comment:9 in reply to: ↑ 7 ; follow-up: Changed 6 years ago by vdelecroix

Replying to jdemeyer:

Replying to vdelecroix:

Why is the following in commit b20b2b0

--- a/build/pkgs/pari/package-version.txt
+++ b/build/pkgs/pari/package-version.txt
@@ -1 +1 @@
-2.8-1369-g0e48e9b
+2.8-1369-g0e48e9b.p0

To force a rebuild of auto_gen.pxi, see 9:ticket:17860

Each time we add something to the declaration file of pari or modifiate the generation we should artificially upgrade the package version? Won't this force the build system to download again the pari package? In any case, it forces a useless recompilation of pari...

comment:10 in reply to: ↑ 9 Changed 6 years ago by jdemeyer

Replying to vdelecroix:

Each time we add something to the declaration file of pari or modifiate the generation we should artificially upgrade the package version?

Yes. I agree it's far from optimal, but at least it works. I think it can be improved (using a Makefile for this is probably the best strategy), but I wouldn't want this issue to block this ticket or #17860.

Won't this force the build system to download again the pari package?

No.

comment:11 Changed 6 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to positive_review

comment:12 Changed 6 years ago by vbraun

  • Status changed from positive_review to needs_info

You can't depend on a duplicate ticket as I can't merge it... Whats the real dependency, if any?

comment:13 Changed 6 years ago by jdemeyer

  • Dependencies #6311 deleted
  • Status changed from needs_info to positive_review

comment:14 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/optional_doctest_failure____supersingular_j to b20b2b0a893f410b8bc1550b940cdffa34b0117e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.