Changes between Version 1 and Version 2 of Ticket #18045


Ignore:
Timestamp:
03/24/15 12:25:28 (5 years ago)
Author:
ncohen
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18045 – Description

    v1 v2  
    11As reported on `AskSage` [1], the function `.is_planar` can return wrong results when given a specific embedding to run its computations on.
    22
    3 This actually comes from a mistake in a `if/else` and variable types, as `bool(a_dictionary)` returns `True` when the dictionary is nonempty. The original authors did not seem to be aware of that, and once fixed the code does not mak the mistake again.
     3This actually comes from a mistake in a `if/else` and variable types, as `bool(a_dictionary)` returns `True` when the dictionary is nonempty. The original authors did not seem to be aware of that, and once fixed the code does not make the mistake again.
     4
     5The problem was that the computations were run on the cached embedding (i.e `_embedding`) instead of the one provided by the user.
    46
    57Nathann