Opened 6 years ago

Closed 6 years ago

#18039 closed defect (fixed)

make_gap_list ignores exceptions

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.6
Component: group theory Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: 08c5772 (Commits) Commit: 08c5772d11171e17346ab44cf5e70ae0ffc95686
Dependencies: Stopgaps:

Description (last modified by jdemeyer) 

sage: F.<a> = GF(9, modulus="first_lexicographic")
sage: libgap(Matrix(F, 1,1, [1]))
Exception NotImplementedError: NotImplementedError('conversion of (Givaro) finite field element to GAP not implemented except for fields defined by Conway polynomials.',) in 'sage.libs.gap.element.make_gap_list' ignored
Exception sage.ext.interrupt.interrupt.SignalError: SignalError('Segmentation fault',) in 'sage.libs.gap.element.make_gap_list' ignored
NULL

Change History (7)

comment:1 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/make_gap_list_ignores_exceptions

comment:3 Changed 6 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Commit set to 08c5772d11171e17346ab44cf5e70ae0ffc95686
  • Status changed from new to needs_review

New commits:

​08c5772Allow exceptions in make_gap_list and similar functions

comment:4 Changed 6 years ago by ncohen

  • Status changed from needs_review to positive_review

Good to go,

Nathann

comment:5 Changed 6 years ago by jdemeyer

  • Reviewers set to Nathann Cohen

comment:6 Changed 6 years ago by ncohen

Gloops. Thanks.

Nathann

comment:7 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/make_gap_list_ignores_exceptions to 08c5772d11171e17346ab44cf5e70ae0ffc95686
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.