Opened 5 years ago

Closed 5 years ago

#18037 closed enhancement (fixed)

Use alarm() instead of interrupt_after_delay() in doctests

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.6
Component: doctest coverage Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Peter Bruin
Report Upstream: N/A Work issues:
Branch: b8ed24a (Commits) Commit: b8ed24a0fbbad472f7161f5d61706ad21edd0eba
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

For a while, interrupt_after_delay() was the recommended way to test interrupts. However, since alarms are also handled the same way by Sage, it's better to use alarm().

I have kept interrupt_after_delay() in ecl.pyx since that tests an ECL handler, which apparently doesn't support SIGALRM.

Change History (4)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/use_alarm___instead_of_interrupt_after_delay___in_doctests

comment:2 Changed 5 years ago by jdemeyer

  • Commit set to b8ed24a0fbbad472f7161f5d61706ad21edd0eba
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

b8ed24aUse alarm() instead of interrupt_after_delay()

comment:3 Changed 5 years ago by pbruin

  • Reviewers set to Peter Bruin
  • Status changed from needs_review to positive_review

Looks good to me.

comment:4 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/use_alarm___instead_of_interrupt_after_delay___in_doctests to b8ed24a0fbbad472f7161f5d61706ad21edd0eba
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.