Opened 6 years ago

Closed 6 years ago

#18007 closed enhancement (fixed)

Move includes of interrupt.pxi to pyx files

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.6
Component: cython Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: c98c51a (Commits, GitHub, GitLab) Commit: c98c51a982ee78488a5ff2b01ffe5dfb996ef969
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

Move lines

include "sage/ext/interrupt.pxi"

from .pxd to .pyx files.

In #18027, it will become obligatory to put this include line in the .pyx file.

Change History (12)

comment:1 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/move_includes_of_interrupt_pxi_to_pyx_files

comment:2 Changed 6 years ago by jdemeyer

  • Commit set to ce992d2ac5a68a4dd7328dc088f68007e4b5e4cd
  • Status changed from new to needs_review

New commits:

ce992d2Move includes of interrupt.pxi to .pyx files

comment:3 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:4 Changed 6 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:5 Changed 6 years ago by vbraun

  • Status changed from positive_review to needs_work
Cythonizing sage/graphs/planarity.pyx

Error compiling Cython file:
------------------------------------------------------------
...
    # Building the dictionary associating id to labels
    for id,label in enumerate(g.vertices()):
        label_id[label] = id

    G.n = g.order()
    G.G = <c_adj **> sage_malloc(G.n*sizeof(c_adj *))
                               ^
------------------------------------------------------------

sage/graphs/modular_decomposition.pyx:119:32: undeclared name not builtin: sage_malloc

Error compiling Cython file:
------------------------------------------------------------
...
    # Building the dictionary associating id to labels
    for id,label in enumerate(g.vertices()):
        label_id[label] = id

    G.n = g.order()
    G.G = <c_adj **> sage_malloc(G.n*sizeof(c_adj *))
         ^
------------------------------------------------------------

comment:6 Changed 6 years ago by jdemeyer

This is exactly the problem that #18145 was meant to detect, so that ticket did its job.

comment:7 Changed 6 years ago by jdemeyer

  • Dependencies set to #18145

comment:8 Changed 6 years ago by jdemeyer

  • Dependencies #18145 deleted

comment:9 Changed 6 years ago by git

  • Commit changed from ce992d2ac5a68a4dd7328dc088f68007e4b5e4cd to c98c51a982ee78488a5ff2b01ffe5dfb996ef969

Branch pushed to git repo; I updated commit sha1. New commits:

c98c51aAdd includes to modular_decomposition.pyx

comment:10 Changed 6 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:11 Changed 6 years ago by vbraun

  • Status changed from needs_review to positive_review

comment:12 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/move_includes_of_interrupt_pxi_to_pyx_files to c98c51a982ee78488a5ff2b01ffe5dfb996ef969
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.