Changes between Version 131 and Version 178 of Ticket #17979


Ignore:
Timestamp:
03/27/15 07:53:24 (4 years ago)
Author:
nthiery
Comment:

Ok, I believe all the points that have been raised have been catered for (but some may have slipped through in this long thread). So this is up for formal review.

Thanks for all the comments and suggestions!

Note: please see the description where I left two points where feedback is specifically welcome.


New commits:

9bf94c417979: moved min_sum and max_sum later in the __init__ arguments
f73c43f17979: trivial doctest fix

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17979

    • Property Status changed from needs_work to needs_review
    • Property Commit changed from 8e51e7ba310308d0ef8787519986d01ca24bc79e to f73c43fd4423675f9ce279da9bb929a44db31483
  • Ticket #17979 – Description

    v131 v178  
    55Remaining design points:
    66
    7 - Do we want to keep the feature that after `min_length`, lists are "considered up to trailing zeroes".
    87- Renaming all the attributes (`.floor`, ...) to private attributes
    98- Double check to logic for improper lexicographic iterability detection