Opened 6 years ago

Closed 6 years ago

#17961 closed defect (duplicate)

Move darwin_utilities to a directory of its own

Reported by: gouezel Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: porting: BSD Keywords:
Cc: Merged in:
Authors: Sebastien Gouezel Reviewers:
Report Upstream: N/A Work issues:
Branch: u/gouezel/darwin_subdir (Commits, GitHub, GitLab) Commit: d7b5d2477268f92a4fd39b6f71fddcdb2980ad2f
Dependencies: #18145 Stopgaps:

Status badges

Description

Since #17767, all pyx files in sage/misc are compiled on all platforms, due to the following line in modules_list.py:

Extension('*', ['sage/misc/*.pyx'])

This is in particular the case of sage/misc/darwin_utilities.pyx, which should however only be included on Darwin as specified on lines 2096 and following of modules_list.py:

# Only include darwin_utilities on OS_X >= 10.5

This ticket moves this file and its friends to a subdirectory of its own.

Change History (12)

comment:1 Changed 6 years ago by gouezel

  • Status changed from new to needs_review

NB: the patch is untested as I don't have a Mac...

comment:2 Changed 6 years ago by jdemeyer

I would not put this inside misc but perhaps a new top-level directory like src/sage/platform.

comment:3 Changed 6 years ago by git

  • Commit changed from 7b10c3ad9be531c4b4ea71762f4bd7ac0a03c4e3 to 41df0ece01934a966200922e3d47cbfc06f0e121

Branch pushed to git repo; I updated commit sha1. New commits:

41df0ec #17961: move darwin_utilities to a new sage/platforms directory

comment:4 Changed 6 years ago by jdemeyer

If you really go for a src/sage/platforms/darwin/ directory, you can drop the darwin_ prefix on all files.

comment:5 Changed 6 years ago by jdemeyer

  • Component changed from build to porting: BSD
  • Status changed from needs_review to needs_work

comment:6 Changed 6 years ago by git

  • Commit changed from 41df0ece01934a966200922e3d47cbfc06f0e121 to d7b5d2477268f92a4fd39b6f71fddcdb2980ad2f

Branch pushed to git repo; I updated commit sha1. New commits:

d7b5d24 #17961: shorten file names

comment:7 Changed 6 years ago by gouezel

  • Status changed from needs_work to needs_review

Good idea, done.

comment:8 Changed 6 years ago by jdemeyer

I have no more comments but somebody with OS X (not me, unfortunately) should test this.

comment:9 Changed 6 years ago by jdemeyer

I think that #18145 also fixes the issue on this ticket, but in a completely different way.

comment:10 Changed 6 years ago by jdemeyer

  • Dependencies set to #18145
  • Status changed from needs_review to needs_work

In any case, this patch will conflict with #18145.

comment:11 Changed 6 years ago by gouezel

  • Milestone changed from sage-6.6 to sage-duplicate/invalid/wontfix
  • Status changed from needs_work to positive_review

Indeed, #18145 fixes the issue, so this ticket is not needed any more.

comment:12 Changed 6 years ago by vbraun

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.