Opened 8 years ago

Closed 7 years ago

#17956 closed defect (fixed)

Put back stopgap for IntegerListsLex

Reported by: Jeroen Demeyer Owned by:
Priority: blocker Milestone: sage-duplicate/invalid/wontfix
Component: combinatorics Keywords:
Cc: Nathann Cohen, Anne Schilling, Travis Scrimshaw Merged in:
Authors: Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

As shown in #17548, there are still plenty of bugs in Partitions and Compositions, so we should undo the IntegerListsLexPublic stuff introduced in #17898.

For a real solution to the problem with IntegerListsLex, see #17920 and #17979.

Change History (12)

comment:1 Changed 8 years ago by Jeroen Demeyer

Branch: u/jdemeyer/stopgap_for_partitions_compositions

comment:2 Changed 8 years ago by Jeroen Demeyer

Authors: Jeroen Demeyer
Commit: df36580013de99675ecd3899a31945af27d818eb
Status: newneeds_review

New commits:

df36580Stopgap for Partitions() and Compositions()

comment:3 Changed 8 years ago by Nathann Cohen

This is madness. The very function which returns wrong results has no stopgap, and now we find ourselves adding stopgaps to all functions that call it.

comment:4 Changed 8 years ago by Jeroen Demeyer

What's the alternative, reverting #17898? I wouldn't mind...

comment:5 Changed 8 years ago by Nathann Cohen

Perhaps we should do that. I mean: get rid of IntegerListsLexPublic, and have a flag in IntegerListsLex saying "I don't want to see the warning". At least we list not have to manually change the imports. Someone proposed that in the mailing lists at some point.

We would buy peace by just making the crystal code call these things without warning.

Nathann

Last edited 8 years ago by Nathann Cohen (previous) (diff)

comment:6 Changed 8 years ago by Volker Braun

Since there is a SageDays on algebraic combinatorics next week, maybe some of the experts in the field can form a plan. I tentatively added it as a project to http://wiki.sagemath.org/days64, though I won't be there.

comment:7 Changed 8 years ago by Nathann Cohen

Should we close this ticket ? Really, adding warnings to the functions that call IntegerListsLex is a bad way out... We need to solve the actual problem.

Nathann

comment:8 Changed 8 years ago by Jeroen Demeyer

Description: modified (diff)
Status: needs_reviewneeds_work
Summary: Stopgap for Partitions/CompositionsPut back stopgap for IntegerListsLex

comment:9 Changed 8 years ago by Jeroen Demeyer

Description: modified (diff)

comment:10 Changed 7 years ago by Volker Braun

Milestone: sage-6.6sage-duplicate/invalid/wontfix
Status: needs_workneeds_review

I guess we can close this as fixed...

comment:11 Changed 7 years ago by Travis Scrimshaw

Authors: Jeroen Demeyer
Branch: u/jdemeyer/stopgap_for_partitions_compositions
Commit: df36580013de99675ecd3899a31945af27d818eb
Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

I concur.

comment:12 Changed 7 years ago by Volker Braun

Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.