Opened 4 years ago
Closed 4 years ago
#17956 closed defect (fixed)
Put back stopgap for IntegerListsLex
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | blocker | Milestone: | sage-duplicate/invalid/wontfix |
Component: | combinatorics | Keywords: | |
Cc: | ncohen, aschilling, tscrim | Merged in: | |
Authors: | Reviewers: | Travis Scrimshaw | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Change History (12)
comment:1 Changed 4 years ago by
- Branch set to u/jdemeyer/stopgap_for_partitions_compositions
comment:2 Changed 4 years ago by
- Commit set to df36580013de99675ecd3899a31945af27d818eb
- Status changed from new to needs_review
comment:3 Changed 4 years ago by
This is madness. The very function which returns wrong results has no stopgap, and now we find ourselves adding stopgaps to all functions that call it.
comment:4 Changed 4 years ago by
What's the alternative, reverting #17898? I wouldn't mind...
comment:5 Changed 4 years ago by
Perhaps we should do that. I mean: get rid of IntegerListsLexPublic
, and have a flag in IntegerListsLex
saying "I don't want to see the warning". At least we list not have to manually change the imports. Someone proposed that in the mailing lists at some point.
We would buy peace by just making the crystal code call these things without warning.
Nathann
comment:6 Changed 4 years ago by
Since there is a SageDays on algebraic combinatorics next week, maybe some of the experts in the field can form a plan. I tentatively added it as a project to http://wiki.sagemath.org/days64, though I won't be there.
comment:7 Changed 4 years ago by
Should we close this ticket ? Really, adding warnings to the functions that call IntegerListsLex
is a bad way out... We need to solve the actual problem.
Nathann
comment:8 Changed 4 years ago by
- Description modified (diff)
- Status changed from needs_review to needs_work
- Summary changed from Stopgap for Partitions/Compositions to Put back stopgap for IntegerListsLex
comment:9 Changed 4 years ago by
- Description modified (diff)
comment:10 Changed 4 years ago by
- Milestone changed from sage-6.6 to sage-duplicate/invalid/wontfix
- Status changed from needs_work to needs_review
I guess we can close this as fixed...
comment:11 Changed 4 years ago by
- Branch u/jdemeyer/stopgap_for_partitions_compositions deleted
- Commit df36580013de99675ecd3899a31945af27d818eb deleted
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
I concur.
comment:12 Changed 4 years ago by
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
Stopgap for Partitions() and Compositions()