Opened 5 years ago

Closed 5 years ago

#17956 closed defect (fixed)

Put back stopgap for IntegerListsLex

Reported by: jdemeyer Owned by:
Priority: blocker Milestone: sage-duplicate/invalid/wontfix
Component: combinatorics Keywords:
Cc: ncohen, aschilling, tscrim Merged in:
Authors: Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

As shown in #17548, there are still plenty of bugs in Partitions and Compositions, so we should undo the IntegerListsLexPublic stuff introduced in #17898.

For a real solution to the problem with IntegerListsLex, see #17920 and #17979.

Change History (12)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/stopgap_for_partitions_compositions

comment:2 Changed 5 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Commit set to df36580013de99675ecd3899a31945af27d818eb
  • Status changed from new to needs_review

New commits:

df36580Stopgap for Partitions() and Compositions()

comment:3 Changed 5 years ago by ncohen

This is madness. The very function which returns wrong results has no stopgap, and now we find ourselves adding stopgaps to all functions that call it.

comment:4 Changed 5 years ago by jdemeyer

What's the alternative, reverting #17898? I wouldn't mind...

comment:5 Changed 5 years ago by ncohen

Perhaps we should do that. I mean: get rid of IntegerListsLexPublic, and have a flag in IntegerListsLex saying "I don't want to see the warning". At least we list not have to manually change the imports. Someone proposed that in the mailing lists at some point.

We would buy peace by just making the crystal code call these things without warning.

Nathann

Last edited 5 years ago by ncohen (previous) (diff)

comment:6 Changed 5 years ago by vbraun

Since there is a SageDays on algebraic combinatorics next week, maybe some of the experts in the field can form a plan. I tentatively added it as a project to http://wiki.sagemath.org/days64, though I won't be there.

comment:7 Changed 5 years ago by ncohen

Should we close this ticket ? Really, adding warnings to the functions that call IntegerListsLex is a bad way out... We need to solve the actual problem.

Nathann

comment:8 Changed 5 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from needs_review to needs_work
  • Summary changed from Stopgap for Partitions/Compositions to Put back stopgap for IntegerListsLex

comment:9 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:10 Changed 5 years ago by vbraun

  • Milestone changed from sage-6.6 to sage-duplicate/invalid/wontfix
  • Status changed from needs_work to needs_review

I guess we can close this as fixed...

comment:11 Changed 5 years ago by tscrim

  • Authors Jeroen Demeyer deleted
  • Branch u/jdemeyer/stopgap_for_partitions_compositions deleted
  • Commit df36580013de99675ecd3899a31945af27d818eb deleted
  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

I concur.

comment:12 Changed 5 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.