Opened 15 years ago
Last modified 8 years ago
#1795 needs_work defect
[with patch, needs work] Adds support for cdef'd functions to sage-coverage
Reported by: | David Roe | Owned by: | Mike Hansen |
---|---|---|---|
Priority: | minor | Milestone: | sage-6.4 |
Component: | doctest coverage | Keywords: | |
Cc: | Jason Grout | Merged in: | |
Authors: | Reviewers: | ||
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
sage-coverage does not check cdef'd functions. This patch fixes that problem.
Attachments (2)
Change History (15)
Changed 15 years ago by
Attachment: | cdef-coverage.patch added |
---|
comment:1 follow-up: 2 Changed 15 years ago by
Summary: | [with-patch] Adds support for cdef'd and cpdef'd functions to sage-coverage → [with-patch, preliminary review] Adds support for cdef'd and cpdef'd functions to sage-coverage |
---|
At a quick glance it looks good. Also I agree with the design decisions. Does it work when run on all our codebase?
Changed 15 years ago by
Attachment: | class-coverage.patch added |
---|
A minor fix to how Python classes are printed
comment:2 Changed 15 years ago by
It gives reasonable output on sage -coverageall and gives reasonable output on a few selected files (integer.pyx, padic_capped_relative_element.pyx, graph.py).
comment:3 Changed 15 years ago by
Milestone: | sage-2.11 → sage-2.10.4 |
---|
comment:4 Changed 14 years ago by
Owner: | changed from David Roe to Mike Hansen |
---|---|
Status: | new → assigned |
comment:6 Changed 14 years ago by
Summary: | [with-patch, preliminary review] Adds support for cdef'd and cpdef'd functions to sage-coverage → [with-patch, needs work] Adds support for cdef'd and cpdef'd functions to sage-coverage |
---|
Ok, we should get this rebased. I think that since we do not test cdef-ed functions those should not be accounted for.
Thoughts?
Cheers,
Michael
comment:7 Changed 14 years ago by
Summary: | [with-patch, needs work] Adds support for cdef'd and cpdef'd functions to sage-coverage → [with patch, needs work] Adds support for cdef'd and cpdef'd functions to sage-coverage |
---|
Fix the summary so it is picked up by the right reports.
Cheers,
Michael
comment:8 Changed 13 years ago by
Cc: | Jason Grout added |
---|
comment:9 Changed 10 years ago by
Description: | modified (diff) |
---|---|
Report Upstream: | → N/A |
Summary: | [with patch, needs work] Adds support for cdef'd and cpdef'd functions to sage-coverage → [with patch, needs work] Adds support for cdef'd functions to sage-coverage |
The question I would like to see answered is: should we check cdef
functions? We already check cpdef
functions.
comment:10 Changed 9 years ago by
Milestone: | sage-5.11 → sage-5.12 |
---|
comment:11 Changed 9 years ago by
Milestone: | sage-6.1 → sage-6.2 |
---|
comment:12 Changed 9 years ago by
Milestone: | sage-6.2 → sage-6.3 |
---|
comment:13 Changed 8 years ago by
Milestone: | sage-6.3 → sage-6.4 |
---|
Adds cdef, cpdef support to sage-coverage