Opened 11 years ago

Last modified 5 years ago

#1795 needs_work defect

[with patch, needs work] Adds support for cdef'd functions to sage-coverage

Reported by: roed Owned by: mhansen
Priority: minor Milestone: sage-6.4
Component: doctest coverage Keywords:
Cc: jason Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

sage-coverage does not check cdef'd functions. This patch fixes that problem.

Attachments (2)

cdef-coverage.patch (5.6 KB) - added by roed 11 years ago.
Adds cdef, cpdef support to sage-coverage
class-coverage.patch (1.3 KB) - added by roed 11 years ago.
A minor fix to how Python classes are printed

Download all attachments as: .zip

Change History (15)

Changed 11 years ago by roed

Adds cdef, cpdef support to sage-coverage

comment:1 follow-up: Changed 11 years ago by was

  • Summary changed from [with-patch] Adds support for cdef'd and cpdef'd functions to sage-coverage to [with-patch, preliminary review] Adds support for cdef'd and cpdef'd functions to sage-coverage

At a quick glance it looks good. Also I agree with the design decisions. Does it work when run on all our codebase?

Changed 11 years ago by roed

A minor fix to how Python classes are printed

comment:2 in reply to: ↑ 1 Changed 11 years ago by roed

It gives reasonable output on sage -coverageall and gives reasonable output on a few selected files (integer.pyx, padic_capped_relative_element.pyx, graph.py).

comment:3 Changed 11 years ago by rlm

  • Milestone changed from sage-2.11 to sage-2.10.4

comment:4 Changed 11 years ago by mhansen

  • Owner changed from roed to mhansen
  • Status changed from new to assigned

comment:5 Changed 11 years ago by robertwb

This no longer applies cleanly (against, e.g. 3.1.3)

comment:6 Changed 10 years ago by mabshoff

  • Summary changed from [with-patch, preliminary review] Adds support for cdef'd and cpdef'd functions to sage-coverage to [with-patch, needs work] Adds support for cdef'd and cpdef'd functions to sage-coverage

Ok, we should get this rebased. I think that since we do not test cdef-ed functions those should not be accounted for.

Thoughts?

Cheers,

Michael

comment:7 Changed 10 years ago by mabshoff

  • Summary changed from [with-patch, needs work] Adds support for cdef'd and cpdef'd functions to sage-coverage to [with patch, needs work] Adds support for cdef'd and cpdef'd functions to sage-coverage

Fix the summary so it is picked up by the right reports.

Cheers,

Michael

comment:8 Changed 10 years ago by jason

  • Cc jason added

comment:9 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Report Upstream set to N/A
  • Summary changed from [with patch, needs work] Adds support for cdef'd and cpdef'd functions to sage-coverage to [with patch, needs work] Adds support for cdef'd functions to sage-coverage

The question I would like to see answered is: should we check cdef functions? We already check cpdef functions.

comment:10 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:11 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:12 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:13 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4
Note: See TracTickets for help on using tickets.