Opened 15 years ago

Last modified 8 years ago

#1795 needs_work defect

[with patch, needs work] Adds support for cdef'd functions to sage-coverage

Reported by: David Roe Owned by: Mike Hansen
Priority: minor Milestone: sage-6.4
Component: doctest coverage Keywords:
Cc: Jason Grout Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

sage-coverage does not check cdef'd functions. This patch fixes that problem.

Attachments (2)

cdef-coverage.patch (5.6 KB) - added by David Roe 15 years ago.
Adds cdef, cpdef support to sage-coverage
class-coverage.patch (1.3 KB) - added by David Roe 15 years ago.
A minor fix to how Python classes are printed

Download all attachments as: .zip

Change History (15)

Changed 15 years ago by David Roe

Attachment: cdef-coverage.patch added

Adds cdef, cpdef support to sage-coverage

comment:1 Changed 15 years ago by William Stein

Summary: [with-patch] Adds support for cdef'd and cpdef'd functions to sage-coverage[with-patch, preliminary review] Adds support for cdef'd and cpdef'd functions to sage-coverage

At a quick glance it looks good. Also I agree with the design decisions. Does it work when run on all our codebase?

Changed 15 years ago by David Roe

Attachment: class-coverage.patch added

A minor fix to how Python classes are printed

comment:2 in reply to:  1 Changed 15 years ago by David Roe

It gives reasonable output on sage -coverageall and gives reasonable output on a few selected files (integer.pyx, padic_capped_relative_element.pyx, graph.py).

comment:3 Changed 15 years ago by Robert Miller

Milestone: sage-2.11sage-2.10.4

comment:4 Changed 14 years ago by Mike Hansen

Owner: changed from David Roe to Mike Hansen
Status: newassigned

comment:5 Changed 14 years ago by Robert Bradshaw

This no longer applies cleanly (against, e.g. 3.1.3)

comment:6 Changed 14 years ago by Michael Abshoff

Summary: [with-patch, preliminary review] Adds support for cdef'd and cpdef'd functions to sage-coverage[with-patch, needs work] Adds support for cdef'd and cpdef'd functions to sage-coverage

Ok, we should get this rebased. I think that since we do not test cdef-ed functions those should not be accounted for.

Thoughts?

Cheers,

Michael

comment:7 Changed 14 years ago by Michael Abshoff

Summary: [with-patch, needs work] Adds support for cdef'd and cpdef'd functions to sage-coverage[with patch, needs work] Adds support for cdef'd and cpdef'd functions to sage-coverage

Fix the summary so it is picked up by the right reports.

Cheers,

Michael

comment:8 Changed 13 years ago by Jason Grout

Cc: Jason Grout added

comment:9 Changed 10 years ago by Jeroen Demeyer

Description: modified (diff)
Report Upstream: N/A
Summary: [with patch, needs work] Adds support for cdef'd and cpdef'd functions to sage-coverage[with patch, needs work] Adds support for cdef'd functions to sage-coverage

The question I would like to see answered is: should we check cdef functions? We already check cpdef functions.

comment:10 Changed 9 years ago by Jeroen Demeyer

Milestone: sage-5.11sage-5.12

comment:11 Changed 9 years ago by For batch modifications

Milestone: sage-6.1sage-6.2

comment:12 Changed 9 years ago by For batch modifications

Milestone: sage-6.2sage-6.3

comment:13 Changed 8 years ago by For batch modifications

Milestone: sage-6.3sage-6.4
Note: See TracTickets for help on using tickets.